-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix refs local marshalling #2812
Conversation
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
marshal := func(v interface{}) (io.Reader, error) { | ||
obj, ok := v.(*RefWrapper) | ||
if !ok { | ||
fmt.Println("%#v", v) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should make this a log.Errorf or a log.Warningf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it isn't needed, it might be a left over from someone debugging something.
It got here when I was rearranging the code.
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
@RichardLitt this changes the API |
Thanks @whyrusleeping. See ipfs-inactive/http-api-spec#98. |
This is a breaking change, right? The summary in the changelog DOES NOT imply it:
|
The changelog should say something like:
|
You can get the old behaviour using I shouldn't have disregarded this. |
Lets change the changelog to say:
|
Part of #2803