Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return nil Bytes() if the Cid in undef. #141

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Aug 18, 2022

No description provided.

@welcome
Copy link

welcome bot commented Aug 18, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@Stebalien
Copy link
Member

LGTM, but could you document this before merging?

@github-actions
Copy link

Suggested version: v0.3.0
Comparing to: v0.2.0 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# github.com/ipfs/go-cid
## compatible changes
MustParse: added

# summary
Suggested version: v0.3.0

gocompat says:

(empty)

@Jorropo Jorropo merged commit 085afa8 into master Aug 25, 2022
@Jorropo Jorropo deleted the Jorropo-patch-1 branch August 25, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants