Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

sync: update CI config files #485

Merged
merged 6 commits into from
Jun 24, 2021
Merged

sync: update CI config files #485

merged 6 commits into from
Jun 24, 2021

Conversation

web3-bot
Copy link
Collaborator

@web3-bot web3-bot commented May 12, 2021

Syncing to commit protocol/.github@c444802.

@welcome
Copy link

welcome bot commented May 12, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@marten-seemann
Copy link
Member

Tests failing due to #481.

We'll also have to disable CircleCI for this repo.

@Stebalien
Copy link
Member

I'm going to just disable that test.

@Stebalien Stebalien force-pushed the web3-bot/sync branch 3 times, most recently from 978ffe3 to d2cb97a Compare May 17, 2021 16:15
@Stebalien
Copy link
Member

Nevermind. I'm updating my expectation on fixing these tests to 1 (maybe 2) days of head scratching. Luckily, most of this head scratching can be done by just about anyone.

@BigLep
Copy link

BigLep commented Jun 9, 2021

@coryschwartz : I'm working to get you access to this repo so I can assign this issue to you, but we want this to get merged during your rotation. Any flaky tests that you need to disable, can you create tracking issues for and add to ipfs/boxo#86 if they aren't already there?

@coryschwartz coryschwartz self-assigned this Jun 10, 2021
@coryschwartz
Copy link

I broke up the big TestWantlistRebroadcast test, which was flaky.
It passes now. There were multiple tests going on there and there might have been something goin on with the timing and rebroadcast intervals that was making it work inconstently.

◉ go test -count 1000 -run  TestWantlistRebroadcastBroadcastsAllWanthaves -run TestWantlistRebroadcastBroadcastInterval -run TestWantlistRebroadcastCancels
PASS
ok      github.com/ipfs/go-bitswap/internal/messagequeue        10.934s

@Stebalien
Copy link
Member

@coryschwartz did you make your changes on this PR? If you still have them locally, please force-push them to a new PR. Unfortunately, the "auto deploy" logic is overwriting this PR.

@Stebalien
Copy link
Member

I'm going to merge this as having broken CI is better than no CI.

@Stebalien Stebalien merged commit 1ab2321 into master Jun 24, 2021
@Stebalien Stebalien deleted the web3-bot/sync branch June 24, 2021 17:20
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
62 tasks
Jorropo pushed a commit to Jorropo/go-libipfs that referenced this pull request Jan 26, 2023
sync: update CI config files

This commit was moved from ipfs/go-bitswap@1ab2321
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants