-
Notifications
You must be signed in to change notification settings - Fork 112
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
Tests failing due to #481. We'll also have to disable CircleCI for this repo. |
I'm going to just disable that test. |
978ffe3
to
d2cb97a
Compare
Nevermind. I'm updating my expectation on fixing these tests to 1 (maybe 2) days of head scratching. Luckily, most of this head scratching can be done by just about anyone. |
@coryschwartz : I'm working to get you access to this repo so I can assign this issue to you, but we want this to get merged during your rotation. Any flaky tests that you need to disable, can you create tracking issues for and add to ipfs/boxo#86 if they aren't already there? |
I broke up the big TestWantlistRebroadcast test, which was flaky.
|
@coryschwartz did you make your changes on this PR? If you still have them locally, please force-push them to a new PR. Unfortunately, the "auto deploy" logic is overwriting this PR. |
I'm going to merge this as having broken CI is better than no CI. |
sync: update CI config files This commit was moved from ipfs/go-bitswap@1ab2321
Syncing to commit protocol/.github@c444802.