Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Flaky TestWantlistRebroadcast test #481

Closed
Stebalien opened this issue May 1, 2021 · 3 comments
Closed

Flaky TestWantlistRebroadcast test #481

Stebalien opened this issue May 1, 2021 · 3 comments
Assignees
Labels
kind/test Testing work need/triage Needs initial labeling and prioritization topic/test failure Topic test failure

Comments

@Stebalien
Copy link
Member

The last step is collecting no messages, leading to a panic:

panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

goroutine 391 [running]:
testing.tRunner.func1.2(0x86de00, 0xc00002c288)
	/usr/lib/go/src/testing/testing.go:1143 +0x332
testing.tRunner.func1(0xc000083b00)
	/usr/lib/go/src/testing/testing.go:1146 +0x4b6
panic(0x86de00, 0xc00002c288)
	/usr/lib/go/src/runtime/panic.go:965 +0x1b9
github.com/ipfs/go-bitswap/internal/messagequeue.TestWantlistRebroadcast(0xc000083b00)
	/home/steb/src/github.com/ipfs/go-bitswap/internal/messagequeue/messagequeue_test.go:451 +0xd3b
testing.tRunner(0xc000083b00, 0x9dac48)
	/usr/lib/go/src/testing/testing.go:1193 +0xef
created by testing.(*T).Run
	/usr/lib/go/src/testing/testing.go:1238 +0x2b3
exit status 2
FAIL	github.com/ipfs/go-bitswap/internal/messagequeue	5.428s

To reproduce, run go test -count 100 -run TestWantlistRebroadcast.

@Stebalien Stebalien added topic/test failure Topic test failure kind/test Testing work need/triage Needs initial labeling and prioritization labels May 1, 2021
@Stebalien Stebalien assigned dirkmc and unassigned dirkmc May 17, 2021
@schomatis
Copy link
Contributor

Assigning myself mainly because I want to learn more about bitswap but probably I'm not the best candidate for this, so feel free to unassign me if we need this fixed asap.

@schomatis schomatis self-assigned this Dec 23, 2021
@schomatis
Copy link
Contributor

@Stebalien I can't reproduce the error, is this issue still relevant?

go test ./internal/messagequeue/ -count 1000 -run TestWantlistRebroadcast -v

@BigLep
Copy link

BigLep commented Mar 5, 2022

@schomatis : I'm closing since can't reproduce.

@BigLep BigLep closed this as completed Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/test Testing work need/triage Needs initial labeling and prioritization topic/test failure Topic test failure
Projects
None yet
Development

No branches or pull requests

4 participants