Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using BigInt #487

Closed
achingbrain opened this issue Dec 20, 2019 · 3 comments · Fixed by #737 or #761
Closed

Allow using BigInt #487

achingbrain opened this issue Dec 20, 2019 · 3 comments · Fixed by #737 or #761
Assignees
@hugomrdias
Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP

Comments

@achingbrain
Copy link
Member

Our eslint rules don't allow BigInts to be used.

const foo = BigInt(5)
  91:35  error  'BigInt' is not defined  no-undef
@achingbrain achingbrain mentioned this issue Dec 28, 2019
Merged
@hugomrdias hugomrdias added exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP labels Jan 6, 2020
@hugomrdias
Copy link
Member

feel free to re open this if this still happens. last release should have a fix for this.

@achingbrain
Copy link
Member Author

I'm still seeing 91:26 error 'BigInt' is not defined no-undef with [email protected].

Do we need to add it to our globals?

Some discussion here: eslint/eslint#11524 (comment)

@achingbrain achingbrain reopened this Feb 20, 2020
@achingbrain achingbrain mentioned this issue Jan 29, 2021
Merged
@hugomrdias hugomrdias mentioned this issue Feb 23, 2021
Merged
3 tasks
@achingbrain
Copy link
Member Author

Still broken, TS now:

../ipfs-unixfs/test/unixfs-format.spec.js(221,14): error TS2737: BigInt literals are not available when targeting lower than ES2020.

@achingbrain achingbrain reopened this Mar 18, 2021
@hugomrdias hugomrdias mentioned this issue Mar 22, 2021
Merged
@hugomrdias hugomrdias self-assigned this Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hugomrdias hugomrdias

Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

release v31 ipfs/aegir
fix: update deps and change ts lib to es2020 ipfs/aegir
2 participants
@hugomrdias @achingbrain