-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructions to demonstrate this? #9
Comments
Some more info ... in case its useful Hope that's helpful ... |
I created a pull request to fix the problems above and upgrade to newer webpack and ipfs |
Hello @mitra42, I tried the current version in master as you described, as well as your PR implementation. The master version worked perfectly for me using the steps as you described:
However, with your version, I couldn't manage to use get Note: The use-from-another-page example should have its usage explained, as you did in the PR. |
Hi Vasco - I'm not sure what the problem was with the PR, I did quite a bit of work on it post this PR to get a service worker version of our archive.app page going. In the end I skipped using the ipfs proxy because it was too hard to follow what the code did, and we needed to make some changes, and instead rewrote message passing to the Service Worker. I'm just in the process of posting it to its own repo which I'll share in a few days, it probably won't get much more attention because we have to use webtorrent for the videos (because of some other IPFS issues) and webtorrent won't currently work in a SW because of the lack of WebRTC in ServiceWorkers. One thing that was definitely clear was that we had to start IPFS at the activate stage, not at the install stage. The install is not getting run on second accesses etc, so as I reported above its trying to access a undefined "node". |
@mitra42 you are right regarding the second access. Master version has problems on a page refresh 🤔 I will appreciate that you share that when available, thanks |
Are there a set of instructions to get this working ?
What I figured so far ...
Then copy all of dist/public+sw to a http server
Access for example /public+sw/index.html
It reports ...
so it looks like the SW is activated.
But ...clicking on window.ipfs.id gets:
and putting a IPFS hash in the input box results in e.g.
So it looks like service worker is getting the request, but it never returns.
I'm not sure if I'm doing something wrong (e.g. I didn't change config from the repo default) or if its still early days for this?
The text was updated successfully, but these errors were encountered: