Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipfs-desktop > Trace/breakpoint trap #1362

Closed
commandline-be opened this issue Feb 27, 2020 · 7 comments · Fixed by #1370
Closed

ipfs-desktop > Trace/breakpoint trap #1362

commandline-be opened this issue Feb 27, 2020 · 7 comments · Fixed by #1370
Labels
area/linux Linux kind/bug A bug in existing code (including security flaws)

Comments

@commandline-be
Copy link

installed from latest .deb on a debian derivate

on launch
$ipfs-desktop
$Trace/breakpoint trap

@alphanmoon
Copy link

The same issue on Debian 10 after .deb install:
$ipfs-desktop
$Trace/breakpoint trap

And it's not starting from inside the xfce app menu.

@nekr0z
Copy link

nekr0z commented Mar 3, 2020

Yep, I confirm on Debian 10.

@autonome
Copy link
Contributor

autonome commented Mar 5, 2020

Thanks for reporting, looking asap!

@lidel
Copy link
Member

lidel commented Mar 5, 2020

I believe it is the same problem as described in signalapp/Signal-Desktop#3536.

IUUC this needs to be fixed in electron-builder responsible for creating .deb.
I've added this to v0.10.4 (#1343)

For now, available workarounds are:

@commandline-be @alphanmoon @nekr0z
Let me know if any of this helped. If not, please share the output of uname -a

@lidel lidel added kind/bug A bug in existing code (including security flaws) area/linux Linux labels Mar 5, 2020
@lidel lidel mentioned this issue Mar 5, 2020
22 tasks
@commandline-be
Copy link
Author

commandline-be commented Mar 5, 2020 via email

@lidel
Copy link
Member

lidel commented Mar 10, 2020

Nonsense indeed.. I hoped for a generic fix, but Chrome/Electron sandbox situation on Linux is nearly as bad as the tray icon one (#1153) 🙃

Below is my brain dump. TL;DR: fix is in #1370


As noted in ssbc/patchwork#1217 (comment) and 99999 issues about --no-sandbox one can find on github, nobody seems to agree how to handle this mess.

Ugh.. ok. Even if we ignore security considerations of SUID and are okay with going that route... we can't. Not everywhere:

So.. what are our options given we are bound to Electron and electron-builder?

  • I've seen folks hack around it by reimplementing linux packaging in sequential manner, setting setuid flags on everything linux related apart from appimage and snap
    (example in ElectronMail repo)
    • We have no bandwidth for writing nor maintaining that type of Rube Goldberg machine, and I am not sure if that is even the right thing to do in the first place. What If setuid hack is removed and all this work is for nothing?
  • Best we can do for now is to set executableArgs to --no-sandbox in electron-builder.yml.
    • Done just that in fix: startup on Debian 10 #1370 + updated deps where possible
    • This fixes GUI: will update Exec command in ipfs-desktop.desktop manifest that is run when menu item / icon in desktop environment is clicked.
    • CLI users can always add --no-sandbox manually – will update README.

lidel added a commit that referenced this issue Mar 10, 2020
This disables sandboxing in ipfs-desktop.desktop manifest
which is ised by Desktop Environments for generating menus
and icons used for starting apps.

Rationale can be found at:
#1362 (comment)

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
lidel added a commit that referenced this issue Mar 10, 2020
This disables sandboxing in ipfs-desktop.desktop manifest
which is ised by Desktop Environments for generating menus
and icons used for starting apps.

Rationale can be found at:
#1362 (comment)

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
lidel added a commit that referenced this issue Mar 10, 2020
This disables sandboxing in ipfs-desktop.desktop manifest
which is used by Desktop Environments for generating menus
and icons used for starting apps.

Rationale for this decision can be found at:
#1362 (comment)

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@lidel
Copy link
Member

lidel commented Mar 12, 2020

Hi friends, fyi v0.10.4 shipfs with updated ipfs-desktop.desktop manifest which starts ipfs-desktop with --no-sandbox by default, restoring startup via GUI shortcut on Debian 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/linux Linux kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants