-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon, font, color improvements #40
Conversation
- Includes icon names underneath all icons - Restores to alphabetical order in all sets - Renames stroke_picture.svg to stroke_doc_picture.svg for consistency (this will need to be noted in release, could be breaking change) - Indicates missing icons in all views, not just compare view
More to come
Full icon set now available in both styles
Replaces src/fonts/inter-ui and src/fonts/montserrat with the latest from master branch of their respective GitHub repos. Question though: why are we bringing in all of these assets?
@olizilla, @hacdias and/or @lidel ... would greatly appreciate your eyes on this one.
Thanks all! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my specific comments, I appreciate all the work done here and the icons are much more organized.
Regarding the testing question: I'm not aware on how to test this.
About why we duplicated the fonts repositories: I don't know either. However, it makes more sense to just grab the final fonts.
not got a full review, just wanted to clarify:
The fonts were included as a git subtree... (https://www.atlassian.com/git/tutorials/git-subtree) for maximum traceability and history preservation, which is nice. We dont have to do that, but it would be nice to continue if it doesn't cause issue. |
git-subtree-dir: src/fonts/inter git-subtree-split: 8a1a5153cd558595bcc8aad86a0fb77caa1ad991
git-subtree-dir: src/fonts/montserrat git-subtree-split: 9974b3a51349576efb0a0606e5b1119e2e9549ef
@olizilla Thanks for the subtree info -- set that back up again. |
License: MIT Signed-off-by: Marcin Rataj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: I've smoke-tested his PR against ipfs-companion and ipfs-webui,
did not see any obvious regressions.
Two notes:
- would it be ok to do a major version bump from
0.13.1
to1.0.0
, just to be sure we don't break anything for anyone using liberal semver ranges? - I don't think all "unused" fonts are excluded as noted in the first comment of this PR,
fonts/
still include:Is that on purpose? (those unused files are over 1MB in size)Inter-UI-BlackItalic.woff2 Inter-UI-Black.woff2 Inter-UI-LICENSE.txt Montserrat-BlackItalic.woff2 Montserrat-Black.woff2 Montserrat-ExtraBoldItalic.woff2 Montserrat-ExtraBold.woff2 Montserrat-ExtraLightItalic.woff2 Montserrat-ExtraLight.woff2 Montserrat-LICENSE.txt Montserrat-MediumItalic.woff2 Montserrat-Medium.woff2 Montserrat-ThinItalic.woff2 Montserrat-Thin.woff2
@lidel - good call on the major version. Will do. As for the extraneous files:
Do you mind cleaning and rebuilding and seeing what you get? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM. I cloned it from scratch without any submodules and couldn't find any trace of Inter UI. Also, I agree with @lidel that we should be better off releasing a major version just to make sure we don't break anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried again in a fresh checked out directory and unexpected fonts are gone.
So it was something on my end. I believe its ok to merge.
Proposing this as major release for ipfs-css; fixes a number of outstanding issues.
Closes #21
Closes #28
Unblocks (but doesn't close) ipfs/ipfs-webui#1379
teal
value#3e9096
with#378085
for accessibility as proposed hereAugments (already-closed) #37
vars.scss
andtheme.scss
fromtheme.json
vars.scss
andtheme.scss
up to top level of directory structure, so it's in the same place asipfs.css
Closes #29 - but with question
interui
,inter ui
,inter ui
references to justinter
due to 2019 name change@font-face
support for the following:ExtraLight
300,ExtraLightItalic
300,SemiBold
600,SemiBoldItalic
600,ExtraBold
800,ExtraBoldItalic
800Medium
500,MediumItalic
500,ExtraBold
800,ExtraBoldItalic
800Thin
,ThinItalic
,ExtraLight
,ExtraLightItalic
,Black
,BlackItalic
Black
,BlackItalic
,Light
,LightItalic
,InterDsplay*
,Inter-Thin*
Closes #10
@font-face
support for .woff and .eot fonts in Montserrat@font-face
support for .woff and .otf fonts in InterMiscellany