Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for the 'invalid Read on closed Body' bug in HTTP API #509

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Workaround for the 'invalid Read on closed Body' bug in HTTP API #509

merged 1 commit into from
Jul 2, 2018

Conversation

lidel
Copy link
Member

@lidel lidel commented Jun 29, 2018 •
edited
Loading

This PR:

@lidel
fix: upload workaround for a bug in go-ipfs
b1bf771 
Available workarounds for `http: invalid Read on closed Body` are:
- either patch go-ipfs to disable server-side keep-alive
- or set `Connection: close` on upload request

We detect call to `/api/v0/add` and set `Connection: close`
@lidel lidel added the P0 Critical: Tackled by core team ASAP label Jun 29, 2018
@lidel lidel mentioned this pull request Jun 29, 2018
Closed
@lidel lidel merged commit 065e224 into master Jul 2, 2018
@lidel lidel deleted the fix/multiple-file-failure branch July 2, 2018 08:06
lidel added a commit that referenced this pull request Jul 2, 2018
@lidel
fix: upload workaround for a bug in go-ipfs
ac62df3 
This is just backporting of PR #509
@lidel lidel mentioned this pull request Jul 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lidel