Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to opt-out metrics #2

Closed
3 tasks done
SgtPooki opened this issue Dec 14, 2022 · 4 comments
Closed
3 tasks done

feat: switch to opt-out metrics #2

SgtPooki opened this issue Dec 14, 2022 · 4 comments

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Dec 14, 2022

Note that until ipfs/ipfs-gui#125, ipfs/ipfs-gui#130, and https://discuss.ipfs.tech/t/ipfs-gui-metrics-changes-in-progress/15695 have been available to the community for feedback for enough time (at least two weeks: ETA Jan 20th), we will continue with the implementation we currently have in public-gateway-checker:

@welcome
Copy link

welcome bot commented Dec 14, 2022

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@SgtPooki
Copy link
Member Author

SgtPooki commented Dec 15, 2022

Send a metric when users disable necessary metrics. This would give us a signal about the number of users we have that prefer zero telemetry collection

This would be essentially the only datapoint we have for users that don't want telemetry collected for them, other than any other 'session' or 'view' metrics that are sent prior to them opting-out.

thoughts? @lidel @whizzzkid @tinytb

@lidel
Copy link
Member

lidel commented Dec 15, 2022

I am afraid this is still sending a telemetry: HTTP request will be reporting someone's IP and user-agent.
Lying like that may be problematic from a legal standpoint: IP is considered private information in some jurisdictions.

Opt-out should be opt-out. When user opts-out,send "opt-out" event once, and never send anything again.
You can infer what % of users opted-out from metrics by comparing the rolling averages (e.g. motnhly) of first-install vs opt-out events or something :)

@SgtPooki
Copy link
Member Author

SgtPooki commented Jan 2, 2023

When user opts-out,send "opt-out" event once, and never send anything again.

This is exactly what I'm saying

@tinytb tinytb moved this to In Progress in IPFS-GUI (PL EngRes) Jan 19, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in IPFS-GUI (PL EngRes) Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants