This repository has been archived by the owner on May 13, 2020. It is now read-only.
feat: detect and support window.ipfs.enable experiment #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple heuristic for forward-compatible detection of IPFS API exposed by ipfs-companion License: MIT Signed-off-by: Marcin Rataj <[email protected]>
lidel
force-pushed
the
feat/window.ipfs-2.0
branch
from
09558af
to
c10a688
Compare
20 tasks
alanshaw
suggested changes
Nov 16, 2018
While we are at it, make it possible to request specific permissions and in future other capabilities provided by this interface. License: MIT Signed-off-by: Marcin Rataj <[email protected]>
|
@alanshaw done, check now:
|
hmm, I don't expect to pass "defaults" normally! It suggests something is going to override them...when actually what I pass would usually override anything set by default.
Unless you have something in mind right now I'd suggest sticking to |
License: MIT Signed-off-by: Marcin Rataj <[email protected]>
alanshaw
approved these changes
Nov 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to get the ball rolling, this PR adds a simple heuristic for forward-compatible detection of IPFS API exposed by experimental branch of ipfs-companion: ipfs/ipfs-companion#589
@alanshaw I can take care of releasing this if you make me a colaborator on NPM.