This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
feat: update to new IPLD API #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Jan 28, 2019
|
Thanks for this, very helpful. When are you planning on releasing the new IPLD API properly and not via a GH url? I ask because once it's out I will refactor this module and all the other unix-fs/mfs related ones to remove pull-streams and expose an async API as part of the same Awesome Endeavour. |
|
As soon as possible. If I get a thumbsup from you and @alanshaw that the API looks OK, I'll do a release. |
|
It doesn't look like the README in the API changes branch has been updated to document the new API, is the latest source of truth still ipld/js-ipld#185 ? |
|
@achingbrain Yes ipld/js-ipld#185 is the source of truth, I also updated it. |
|
ipld/js-ipld#190 is the implementation ipld/js-ipld#185 is the API docs update. |
vmx
force-pushed
the
new-ipld-api
branch
2 times, most recently
from
30fdc0d
to
4b209d6
Compare
This is part of the Awesome Endeavour: Async Iterators: ipfs/js-ipfs#1670
|
Superseded by #21 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the Awesome Endeavour: Async Iterators:
ipfs/js-ipfs#1670
Currently it checks out IPLD directly from a branch. The reason is that I'd like to get approval from all users of the new API first, so that I can still make changes while keeping the history clean.