Skip to content
This repository has been archived by the owner on Aug 12, 2020. It is now read-only.

chore: update IPLD to latest version #232

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Conversation

vmx
Copy link
Contributor

@vmx vmx commented Oct 24, 2018

js-ipld 0.19 has breaking changes that affect this project. Therefore
also update the corresponding code.

js-ipld 0.19 has breaking changes that affect this project. Therefore
also update the corresponding code.
@ghost ghost assigned vmx Oct 24, 2018
@ghost ghost added the status/in-progress In progress label Oct 24, 2018
@vmx vmx changed the title chore: update IPLD to latest version [WIP} chore: update IPLD to latest version Oct 24, 2018
Copy link
Contributor Author

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: This is not ready to be merged (even if CI is green). This needs a new js-ipld release first.

@achingbrain
Copy link
Collaborator

As luck would have it, CI is not green 😜

@vmx
Copy link
Contributor Author

vmx commented Oct 25, 2018

@achingbrain The failure seems unrelated to my PR. I see the same one locally on master.

@vmx
Copy link
Contributor Author

vmx commented Oct 26, 2018

CI passed. Please note that it needs ipfs/js-ipfs#1617 to be merged, else tests fail. Though the tests also fail on master without this PR, so I'd say this change is ready to be merged.

@vmx vmx changed the title [WIP} chore: update IPLD to latest version chore: update IPLD to latest version Oct 26, 2018
@vmx vmx requested a review from achingbrain October 26, 2018 09:54
@achingbrain achingbrain merged commit 23be277 into master Oct 26, 2018
@ghost ghost removed the status/in-progress In progress label Oct 26, 2018
@achingbrain achingbrain deleted the update-ipld-0.19 branch October 26, 2018 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants