Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Async Crypto Endeavour #390

Merged
merged 14 commits into from
Nov 7, 2016
Merged

Async Crypto Endeavour #390

merged 14 commits into from
Nov 7, 2016

Conversation

dignifiedquire
Copy link
Contributor

No description provided.

@daviddias
Copy link
Contributor

Seeing these errors:

  1) "before all" hook:
     Error: Uncaught TypeError: Cannot read property 'x-stream-output' of undefined (webpack:///src/request-api.js?0369*****************:30:0 <- test/browser.js:49882)



  2) "after all" hook:
     Error: Uncaught TypeError: Cannot read property 'x-stream-output' of undefined (webpack:///src/request-api.js?0369*****************:30:0 <- test/browser.js:49882)

@daviddias
Copy link
Contributor

So far looks good to me

@dignifiedquire
Copy link
Contributor Author

CI is being super weird...

@daviddias
Copy link
Contributor

Ok, CI is good now, just fails for the test of adding nested dirs on the browser (reported bug: #339).

We've already talked about how to act with regards to this in the past and the decision is to continue moving forward (merge and release), while keep tackling that specific test. To make sure there is no confusion, I'm going to add a note to that in the readme.

@daviddias daviddias merged commit 1d0d57e into master Nov 7, 2016
@daviddias daviddias deleted the webcrypto branch November 7, 2016 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants