Passing a pull-stream to ipfs.add is interpreted as a callback

[olizilla]

If you pass a pull-stream to ipfs.add like:

const pullStream = fileReader(file)
const ipfsRef = await ipfs.files.add(pullStream)

It's interpreted as a callback fn and callbackify is invoked, which causes an error in callbackifyVariadic

Type error: cb is not a function

Passing it as part of an array of entires avoids that issue, but then hits a known issue later on

const pullStream = fileReader(file)
const ipfsRef = await ipfs.files.add([{content: pullStream}])

Error: content.once is not a function

[lidel]

Hm.. is this why interface-ipfs-core spec defines a separate ipfs.files.addPullStream?

[olizilla]

@lidel I agree, it is a little odd, but i think the api is meaningfully different from files.add...

• ipfs.files.add(pullStream) should let you hand a pull-stream to ipfs add and get a ipfsFileRef object back
• ipfs.files.addPullStream() returns a through pull stream, that should let you add things to ipfs as step in a larger pull stream chain.

Neither seems to work as expected currently.

[alanshaw]

Fixed here in: 9884f7c and ca48731

js-ipfs-api issue ipfs-inactive/js-ipfs-http-client#745 and PR ipfs-inactive/js-ipfs-http-client#746

js-ipfs issue ipfs/js-ipfs#1317 and PR ipfs/js-ipfs#1319