Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stack traces to trace.py #621

Closed
brendangregg opened this issue Jul 21, 2016 · 4 comments
Closed

add stack traces to trace.py #621

brendangregg opened this issue Jul 21, 2016 · 4 comments

Comments

@brendangregg
Copy link
Member

Would be useful to have a "-s" to print stack traces.

When used on user-level probes, it would only print the user stack trace. When used on kernel, it could print both.

I did do this for kprobe/uprobe in perf-tools using ftrace, which proved very useful.

https://github.com/brendangregg/perf-tools/blob/master/examples/kprobe_example.txt#L302

@goldshtn
Copy link
Collaborator

Oh yeah, could be very useful, instead of poking around with a debugger. I think in terms of a timeline, I would like things to happen in this order:

  1. USDT support in Python
  2. Add USDT support to my branch of stackcount (this is the only thing I'm blocked on)
  3. Port argdist, trace, tplist to new USDT support
  4. Add stack count support to trace
  5. Add uprobe support to funccount and funclatency

That's my list for the next few weeks I think :) I could also move forward with 2, 4, and 5 to get unblocked and add USDT support later. What do you think?

@brendangregg
Copy link
Member Author

Sounds good. I'll look at getting the (1) code we already have integrated.

@goldshtn
Copy link
Collaborator

@brendangregg I think this can be closed now with @palmtenor 's PR #712. It's not the -s you wanted, but I think -K and -U kind of make sense too.

@brendangregg
Copy link
Member Author

Yes, we can close it, thanks @palmtenor ! And if -KU gets too annoying, we can always add "-s" as an alias for "-KU".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants