From ad9a210ec1573fb42bfa585fc8c919b2ee54d565 Mon Sep 17 00:00:00 2001 From: Gal Rogozinski Date: Sun, 29 Sep 2019 13:25:41 +0300 Subject: [PATCH 1/2] Documentation: Update CONTRIBUTING.MD Add regression tests reference --- CONTRIBUTING.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e90d487b53..459be56b7f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -18,7 +18,11 @@ Before creating a PR make sure you have read the entire contributing guideline. #### **Do you intend to add a new feature or change an existing one?** -* Suggest your change as a [new issues](https://github.com/iotaledger/iri/issues/new). Use the second part of the issue template, dedicated to new feature requests and delete the first part. If you plan on implementing the change yourself, start writing the code and submit a PR. Note that the fact that the feature is "code ready" doesn't mean it will get merged. It is advisable to gather feedback for the change first. You are encouraged to start and drive a discussion on [Discord](https://discordapp.com/invite/fNGZXvh). The IRI team also monitors the repo and will provide feedback where relevant. +* Suggest your change as a [new issues](https://github.com/iotaledger/iri/issues/new). Use the second part of the issue template, dedicated to new feature requests and delete the first part. If you plan on implementing the change yourself, start writing the code and submit a PR. Note that the fact that the feature is "code ready" doesn't mean it will get merged. It is advisable to gather feedback for the change first. You are encouraged to start and drive a discussion on [Discord](https://discordapp.com/invite/fNGZXvh). The IRI team also monitors the repo and will provide feedback where relevant. + +#### **Want to write a regression test for your feature? Or to any other feature that needs a test?** + +* Please refer to our current [regression tests](https://github.com/iotaledger/iri/tree/dev/python-regression). #### **Do you have questions about the functioning of IRI nodes, the network or anything IOTA related?** From 4a85261a6e8f59a9f61df543db6d15e446574b72 Mon Sep 17 00:00:00 2001 From: Gal Rogozinski Date: Tue, 19 Nov 2019 14:22:50 +0200 Subject: [PATCH 2/2] change discord link --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 459be56b7f..70f4435bb3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -18,7 +18,7 @@ Before creating a PR make sure you have read the entire contributing guideline. #### **Do you intend to add a new feature or change an existing one?** -* Suggest your change as a [new issues](https://github.com/iotaledger/iri/issues/new). Use the second part of the issue template, dedicated to new feature requests and delete the first part. If you plan on implementing the change yourself, start writing the code and submit a PR. Note that the fact that the feature is "code ready" doesn't mean it will get merged. It is advisable to gather feedback for the change first. You are encouraged to start and drive a discussion on [Discord](https://discordapp.com/invite/fNGZXvh). The IRI team also monitors the repo and will provide feedback where relevant. +* Suggest your change as a [new issues](https://github.com/iotaledger/iri/issues/new). Use the second part of the issue template, dedicated to new feature requests and delete the first part. If you plan on implementing the change yourself, start writing the code and submit a PR. Note that the fact that the feature is "code ready" doesn't mean it will get merged. It is advisable to gather feedback for the change first. You are encouraged to start and drive a discussion on [Discord](https://discord.iota.org/). The IRI team also monitors the repo and will provide feedback where relevant. #### **Want to write a regression test for your feature? Or to any other feature that needs a test?**