Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Make is_promotable response consistent with check_consistency #262

Closed
lzpap opened this issue Nov 13, 2019 · 0 comments
Closed

Make is_promotable response consistent with check_consistency #262

lzpap opened this issue Nov 13, 2019 · 0 comments
Labels

Comments

@lzpap
Copy link
Member

lzpap commented Nov 13, 2019

We can't control the response from the node in check_consistency, so to make it consistent, I suggest we implement the same behavior in is_promotable, that is to do

if response['promotable']:
    del response['info']

instead of the current response['info']=None in

if response['promotable']:

Originally posted by @lzpap in #261

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant