Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(doc): create a tutorial for DeFi Lend Borrow UI #1685

Merged
merged 14 commits into from
Oct 7, 2024
Merged

feat(doc): create a tutorial for DeFi Lend Borrow UI #1685

merged 14 commits into from
Oct 7, 2024

Conversation

vivekjain23
Copy link
Contributor

Description of change

This PR is part II of the DeFi Lend Borrow tutorial. Creating a Dapp tutorial for DeFi Lend Borrow using React.

Links to any relevant issues

fixes #1665

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@vivekjain23 vivekjain23 marked this pull request as ready for review September 10, 2024 12:29
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9768804

✅ Preview: https://iota-wiki-ho53p7m1u-iota1.vercel.app

lucas-tortora
lucas-tortora requested changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@lucas-tortora lucas-tortora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there no part II file for 1.1?

docs/build/isc/v1.1/docs/tutorials/defi-lend-borrow-tutorial-part-1.md Outdated Show resolved Hide resolved
docs/build/isc/v1.3/docs/tutorials/defi-lend-borrow-tutorial-part-2.md Outdated Show resolved Hide resolved
docs/build/isc/v1.3/docs/tutorials/defi-lend-borrow-tutorial-part-2.md Outdated Show resolved Hide resolved
docs/build/isc/v1.3/docs/tutorials/defi-lend-borrow-tutorial-part-2.md Outdated Show resolved Hide resolved
docs/build/isc/v1.3/docs/tutorials/defi-lend-borrow-tutorial-part-2.md Outdated Show resolved Hide resolved
docs/build/isc/v1.3/docs/tutorials/defi-lend-borrow-tutorial-part-2.md Outdated Show resolved Hide resolved
docs/build/isc/v1.3/docs/tutorials/defi-lend-borrow-tutorial-part-2.md Outdated Show resolved Hide resolved
docs/build/isc/v1.3/docs/tutorials/defi-lend-borrow-tutorial-part-2.md Outdated Show resolved Hide resolved
@vivekjain23 vivekjain23 changed the title feat(doc): create tutorial for DeFi Lend Borrow part II feat(doc): create tutorial for DeFi Lend Borrow UI Sep 12, 2024
@vivekjain23 vivekjain23 force-pushed the feat/defi-lend-borrow-tutorial-part-II branch from bca67ff to 2a0d5b0 Compare September 17, 2024 10:36
lucas-tortora
lucas-tortora requested changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@lucas-tortora lucas-tortora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments regarding style :)

docs/build/isc/v1.3/docs/tutorials/defi-lend-borrow-tutorial-part-2.md Outdated Show resolved Hide resolved
docs/build/isc/v1.3/docs/tutorials/defi-lend-borrow-tutorial-part-2.md Show resolved Hide resolved
docs/build/isc/v1.3/docs/tutorials/defi-lend-borrow-tutorial-part-2.md Outdated Show resolved Hide resolved
docs/build/isc/v1.3/docs/tutorials/defi-lend-borrow-tutorial-part-2.md Outdated Show resolved Hide resolved
docs/build/isc/v1.3/docs/tutorials/defi-lend-borrow-tutorial-part-2.md Outdated Show resolved Hide resolved
docs/build/isc/v1.3/docs/tutorials/defi-lend-borrow-tutorial-part-2.md Outdated Show resolved Hide resolved
docs/build/isc/v1.3/docs/tutorials/defi-lend-borrow-tutorial-part-2.md Outdated Show resolved Hide resolved
@vivekjain23 vivekjain23 changed the title feat(doc): create tutorial for DeFi Lend Borrow UI feat(doc): create a tutorial for DeFi Lend Borrow UI Sep 18, 2024
Ginowine
Ginowine requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@Ginowine Ginowine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi mate, can you please implement those spaces suggestion you fixed on the second PR here? Like adding an empty space between two code blocks.

Ginowine
Ginowine approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@Ginowine Ginowine left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome tutorial 🙌 can't wait to share it on my social media.

@vivekjain23 vivekjain23 merged commit 22ba7c2 into main Oct 7, 2024
9 checks passed
@vivekjain23 vivekjain23 deleted the feat/defi-lend-borrow-tutorial-part-II branch October 7, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@salaheldinsoliman salaheldinsoliman salaheldinsoliman approved these changes

@Ginowine Ginowine Ginowine approved these changes

@Dr-Electron Dr-Electron Awaiting requested review from Dr-Electron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a tutorial for Lending borrowing platform
4 participants
@vivekjain23 @Ginowine @salaheldinsoliman @lucas-tortora