From fc0697080b8e416131a5422f45a2e6700484998e Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 10:10:07 +0300 Subject: [PATCH 01/19] Upgrade docker build action to the latest version --- .github/workflows/docker-develop.yml | 33 ++++++++++++++++++++-------- 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/.github/workflows/docker-develop.yml b/.github/workflows/docker-develop.yml index 849c91b72a..8db44e8256 100644 --- a/.github/workflows/docker-develop.yml +++ b/.github/workflows/docker-develop.yml @@ -14,13 +14,28 @@ jobs: env: DOCKER_BUILDKIT: 1 steps: - - name: Checkout repository - uses: actions/checkout@v2 + - name: Checkout repository + uses: actions/checkout@v2 - - name: Publish to Docker Hub - uses: docker/build-push-action@92e71463491f2d026a477188b8ad3a0fdd9d672c - with: - repository: iotaledger/goshimmer - username: '${{ secrets.IOTALEDGER_HUB_DOCKER_LOGIN }}' - password: '${{ secrets.IOTALEDGER_HUB_DOCKER_PASSWORD }}' - tags: develop + - name: Set up Docker Buildx + uses: docker/setup-buildx-action@v1 + +# - name: Cache Docker layers +# uses: actions/cache@v2 +# with: +# path: /tmp/.buildx-cache +# key: ${{ runner.os }}-buildx-${{ github.sha }} +# restore-keys: | +# ${{ runner.os }}-buildx- + + - name: Login to DockerHub + uses: docker/login-action@v1 + with: + username: '${{ secrets.IOTALEDGER_HUB_DOCKER_LOGIN }}' + password: '${{ secrets.IOTALEDGER_HUB_DOCKER_PASSWORD }}' + + - name: Publish to Docker Hub + uses: docker/build-push-action@v2 + with: + tags: iotaledger/goshimmer:develop + push: true From d69bdb7fca62148c504d0e9d61c414b7f2a0a66d Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 10:34:48 +0300 Subject: [PATCH 02/19] Run on Pull Requests --- .github/workflows/docker-develop.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/docker-develop.yml b/.github/workflows/docker-develop.yml index 8db44e8256..e40d0e68cd 100644 --- a/.github/workflows/docker-develop.yml +++ b/.github/workflows/docker-develop.yml @@ -6,6 +6,9 @@ on: - develop paths-ignore: - 'docs/**' + pull_request: + paths-ignore: + - 'docs/**' jobs: From 0ff8d7c7ee1008e89420ceed7262ce611aaafa63 Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 10:42:10 +0300 Subject: [PATCH 03/19] Add caching to docker develop build --- .github/workflows/docker-develop.yml | 32 ++++++++++++++++++---------- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/.github/workflows/docker-develop.yml b/.github/workflows/docker-develop.yml index e40d0e68cd..e62c1d6c7f 100644 --- a/.github/workflows/docker-develop.yml +++ b/.github/workflows/docker-develop.yml @@ -18,27 +18,37 @@ jobs: DOCKER_BUILDKIT: 1 steps: - name: Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v2.3.4 - name: Set up Docker Buildx - uses: docker/setup-buildx-action@v1 + uses: docker/setup-buildx-action@v1.3.0 -# - name: Cache Docker layers -# uses: actions/cache@v2 -# with: -# path: /tmp/.buildx-cache -# key: ${{ runner.os }}-buildx-${{ github.sha }} -# restore-keys: | -# ${{ runner.os }}-buildx- + - name: Cache Docker layers + uses: actions/cache@v2.1.6 + with: + path: /tmp/.buildx-cache + key: ${{ runner.os }}-buildx-${{ github.sha }} + restore-keys: | + ${{ runner.os }}-buildx- - name: Login to DockerHub - uses: docker/login-action@v1 + uses: docker/login-action@v1.9.0 with: username: '${{ secrets.IOTALEDGER_HUB_DOCKER_LOGIN }}' password: '${{ secrets.IOTALEDGER_HUB_DOCKER_PASSWORD }}' - name: Publish to Docker Hub - uses: docker/build-push-action@v2 + uses: docker/build-push-action@v2.5.0 with: tags: iotaledger/goshimmer:develop push: true + cache-from: type=local,src=/tmp/.buildx-cache + cache-to: type=local,dest=/tmp/.buildx-cache-new + + - # Temp fix + # https://github.com/docker/build-push-action/issues/252 + # https://github.com/moby/buildkit/issues/1896 + name: Move cache + run: | + rm -rf /tmp/.buildx-cache + mv /tmp/.buildx-cache-new /tmp/.buildx-cache From dfa4dacd36263e3518dcd4cba0ec566943b58bf0 Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 10:47:50 +0300 Subject: [PATCH 04/19] Fake changes to verify caching --- plugins/gossip/gossip.go | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/gossip/gossip.go b/plugins/gossip/gossip.go index 1b8451afb7..bbf69cba98 100644 --- a/plugins/gossip/gossip.go +++ b/plugins/gossip/gossip.go @@ -61,6 +61,7 @@ func start(shutdownSignal <-chan struct{}) { // resolve the bind address address := net.JoinHostPort(config.Node().String(local.CfgBind), strconv.Itoa(gossipEndpoint.Port())) localAddr, err := net.ResolveTCPAddr(gossipEndpoint.Network(), address) + if err != nil { log.Fatalf("Error resolving %s: %v", local.CfgBind, err) } From c4ab1f64a00f7821afff39b59e0a437b3cc2c040 Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 11:29:23 +0300 Subject: [PATCH 05/19] Fake 2 --- plugins/gossip/gossip.go | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/gossip/gossip.go b/plugins/gossip/gossip.go index bbf69cba98..4bb3bba42b 100644 --- a/plugins/gossip/gossip.go +++ b/plugins/gossip/gossip.go @@ -66,6 +66,7 @@ func start(shutdownSignal <-chan struct{}) { log.Fatalf("Error resolving %s: %v", local.CfgBind, err) } + listener, err := net.ListenTCP(gossipEndpoint.Network(), localAddr) if err != nil { log.Fatalf("Error listening: %v", err) From df4e0b03ad5b7ca4ec097ca0261a7f36fed6f1b3 Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 11:33:04 +0300 Subject: [PATCH 06/19] Revert "Fake 2" This reverts commit c4ab1f64 --- plugins/gossip/gossip.go | 1 - 1 file changed, 1 deletion(-) diff --git a/plugins/gossip/gossip.go b/plugins/gossip/gossip.go index 4bb3bba42b..bbf69cba98 100644 --- a/plugins/gossip/gossip.go +++ b/plugins/gossip/gossip.go @@ -66,7 +66,6 @@ func start(shutdownSignal <-chan struct{}) { log.Fatalf("Error resolving %s: %v", local.CfgBind, err) } - listener, err := net.ListenTCP(gossipEndpoint.Network(), localAddr) if err != nil { log.Fatalf("Error listening: %v", err) From 87074b4846c6ab7bd230f77446f0e86aa89717b3 Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 11:33:06 +0300 Subject: [PATCH 07/19] Revert "Fake changes to verify caching" This reverts commit dfa4dacd --- plugins/gossip/gossip.go | 1 - 1 file changed, 1 deletion(-) diff --git a/plugins/gossip/gossip.go b/plugins/gossip/gossip.go index bbf69cba98..1b8451afb7 100644 --- a/plugins/gossip/gossip.go +++ b/plugins/gossip/gossip.go @@ -61,7 +61,6 @@ func start(shutdownSignal <-chan struct{}) { // resolve the bind address address := net.JoinHostPort(config.Node().String(local.CfgBind), strconv.Itoa(gossipEndpoint.Port())) localAddr, err := net.ResolveTCPAddr(gossipEndpoint.Network(), address) - if err != nil { log.Fatalf("Error resolving %s: %v", local.CfgBind, err) } From 1990cf3f3a86e7aecfec0827a63ca0713af15844 Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 11:33:42 +0300 Subject: [PATCH 08/19] Add mode max --- .github/workflows/docker-develop.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/docker-develop.yml b/.github/workflows/docker-develop.yml index e62c1d6c7f..5b5868540a 100644 --- a/.github/workflows/docker-develop.yml +++ b/.github/workflows/docker-develop.yml @@ -43,7 +43,7 @@ jobs: tags: iotaledger/goshimmer:develop push: true cache-from: type=local,src=/tmp/.buildx-cache - cache-to: type=local,dest=/tmp/.buildx-cache-new + cache-to: type=local,mode=max,dest=/tmp/.buildx-cache-new - # Temp fix # https://github.com/docker/build-push-action/issues/252 From fe6feb03dd3eca37115a5d304f69039432205630 Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 11:36:48 +0300 Subject: [PATCH 09/19] Fake changes --- plugins/gossip/gossip.go | 1 - 1 file changed, 1 deletion(-) diff --git a/plugins/gossip/gossip.go b/plugins/gossip/gossip.go index 1b8451afb7..d94d7f4c3b 100644 --- a/plugins/gossip/gossip.go +++ b/plugins/gossip/gossip.go @@ -54,7 +54,6 @@ func start(shutdownSignal <-chan struct{}) { defer log.Info("Stopping " + PluginName + " ... done") lPeer := local.GetInstance() - // use the port of the gossip service gossipEndpoint := lPeer.Services().Get(service.GossipKey) From 5c70e380e7da9026cb67aeaf732f57d1944bfcf1 Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 11:42:38 +0300 Subject: [PATCH 10/19] Revert "Fake changes" This reverts commit fe6feb03 --- plugins/gossip/gossip.go | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/gossip/gossip.go b/plugins/gossip/gossip.go index d94d7f4c3b..1b8451afb7 100644 --- a/plugins/gossip/gossip.go +++ b/plugins/gossip/gossip.go @@ -54,6 +54,7 @@ func start(shutdownSignal <-chan struct{}) { defer log.Info("Stopping " + PluginName + " ... done") lPeer := local.GetInstance() + // use the port of the gossip service gossipEndpoint := lPeer.Services().Get(service.GossipKey) From 397e5f45d6cce06fe8201fe947fa00eb514c16b8 Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 11:50:05 +0300 Subject: [PATCH 11/19] Fake commit to trigger cache --- plugins/gossip/gossip.go | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/gossip/gossip.go b/plugins/gossip/gossip.go index 1b8451afb7..5670f3ee6b 100644 --- a/plugins/gossip/gossip.go +++ b/plugins/gossip/gossip.go @@ -58,6 +58,7 @@ func start(shutdownSignal <-chan struct{}) { // use the port of the gossip service gossipEndpoint := lPeer.Services().Get(service.GossipKey) + // resolve the bind address address := net.JoinHostPort(config.Node().String(local.CfgBind), strconv.Itoa(gossipEndpoint.Port())) localAddr, err := net.ResolveTCPAddr(gossipEndpoint.Network(), address) From 4546a2119397b84d2986069cf1a14719a9d9e645 Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 11:58:14 +0300 Subject: [PATCH 12/19] Revert "Fake commit to trigger cache" This reverts commit 397e5f45 --- plugins/gossip/gossip.go | 1 - 1 file changed, 1 deletion(-) diff --git a/plugins/gossip/gossip.go b/plugins/gossip/gossip.go index 5670f3ee6b..1b8451afb7 100644 --- a/plugins/gossip/gossip.go +++ b/plugins/gossip/gossip.go @@ -58,7 +58,6 @@ func start(shutdownSignal <-chan struct{}) { // use the port of the gossip service gossipEndpoint := lPeer.Services().Get(service.GossipKey) - // resolve the bind address address := net.JoinHostPort(config.Node().String(local.CfgBind), strconv.Itoa(gossipEndpoint.Port())) localAddr, err := net.ResolveTCPAddr(gossipEndpoint.Network(), address) From 53cc1a65c231071d4463848280271e80af574cdf Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 11:59:12 +0300 Subject: [PATCH 13/19] Disable caching --- .github/workflows/docker-develop.yml | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/.github/workflows/docker-develop.yml b/.github/workflows/docker-develop.yml index 5b5868540a..d396e4c7dc 100644 --- a/.github/workflows/docker-develop.yml +++ b/.github/workflows/docker-develop.yml @@ -23,14 +23,6 @@ jobs: - name: Set up Docker Buildx uses: docker/setup-buildx-action@v1.3.0 - - name: Cache Docker layers - uses: actions/cache@v2.1.6 - with: - path: /tmp/.buildx-cache - key: ${{ runner.os }}-buildx-${{ github.sha }} - restore-keys: | - ${{ runner.os }}-buildx- - - name: Login to DockerHub uses: docker/login-action@v1.9.0 with: @@ -41,14 +33,4 @@ jobs: uses: docker/build-push-action@v2.5.0 with: tags: iotaledger/goshimmer:develop - push: true - cache-from: type=local,src=/tmp/.buildx-cache - cache-to: type=local,mode=max,dest=/tmp/.buildx-cache-new - - - # Temp fix - # https://github.com/docker/build-push-action/issues/252 - # https://github.com/moby/buildkit/issues/1896 - name: Move cache - run: | - rm -rf /tmp/.buildx-cache - mv /tmp/.buildx-cache-new /tmp/.buildx-cache + push: true \ No newline at end of file From e7bd28b793e499e1456ba27ad646a63925bf5774 Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 13:14:59 +0300 Subject: [PATCH 14/19] Revert "Disable caching" This reverts commit 53cc1a65 --- .github/workflows/docker-develop.yml | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/.github/workflows/docker-develop.yml b/.github/workflows/docker-develop.yml index d396e4c7dc..5b5868540a 100644 --- a/.github/workflows/docker-develop.yml +++ b/.github/workflows/docker-develop.yml @@ -23,6 +23,14 @@ jobs: - name: Set up Docker Buildx uses: docker/setup-buildx-action@v1.3.0 + - name: Cache Docker layers + uses: actions/cache@v2.1.6 + with: + path: /tmp/.buildx-cache + key: ${{ runner.os }}-buildx-${{ github.sha }} + restore-keys: | + ${{ runner.os }}-buildx- + - name: Login to DockerHub uses: docker/login-action@v1.9.0 with: @@ -33,4 +41,14 @@ jobs: uses: docker/build-push-action@v2.5.0 with: tags: iotaledger/goshimmer:develop - push: true \ No newline at end of file + push: true + cache-from: type=local,src=/tmp/.buildx-cache + cache-to: type=local,mode=max,dest=/tmp/.buildx-cache-new + + - # Temp fix + # https://github.com/docker/build-push-action/issues/252 + # https://github.com/moby/buildkit/issues/1896 + name: Move cache + run: | + rm -rf /tmp/.buildx-cache + mv /tmp/.buildx-cache-new /tmp/.buildx-cache From a4f5225cf633649f0be694c3d037bfddbdd2a04c Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 13:23:24 +0300 Subject: [PATCH 15/19] Try Go build cache --- .github/workflows/docker-develop.yml | 2 ++ Dockerfile | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/docker-develop.yml b/.github/workflows/docker-develop.yml index 5b5868540a..c6016e0a37 100644 --- a/.github/workflows/docker-develop.yml +++ b/.github/workflows/docker-develop.yml @@ -40,6 +40,8 @@ jobs: - name: Publish to Docker Hub uses: docker/build-push-action@v2.5.0 with: + build-args: | + mount='id=go_build_cache_mount,type=bind,source=/tmp/foo' tags: iotaledger/goshimmer:develop push: true cache-from: type=local,src=/tmp/.buildx-cache diff --git a/Dockerfile b/Dockerfile index a2ef49bd7c..3557c561a6 100644 --- a/Dockerfile +++ b/Dockerfile @@ -26,7 +26,7 @@ RUN go mod verify # 3. Build the binary # 4. Verify that goshimmer binary is statically linked RUN --mount=target=. \ - --mount=type=cache,target=/root/.cache/go-build \ + --mount=type=cache,id=go_build_cache_mount,target=/root/.cache/go-build \ GOOS=linux GOARCH=amd64 go build \ -tags="$BUILD_TAGS" \ -ldflags='-w -s -extldflags "-static"' \ From 302dcb544b1eeb9755939fb43dce1b230dfc95ef Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 13:38:49 +0300 Subject: [PATCH 16/19] Try manual docker build --- .github/workflows/docker-develop.yml | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/.github/workflows/docker-develop.yml b/.github/workflows/docker-develop.yml index c6016e0a37..5c77f7afac 100644 --- a/.github/workflows/docker-develop.yml +++ b/.github/workflows/docker-develop.yml @@ -37,15 +37,18 @@ jobs: username: '${{ secrets.IOTALEDGER_HUB_DOCKER_LOGIN }}' password: '${{ secrets.IOTALEDGER_HUB_DOCKER_PASSWORD }}' - - name: Publish to Docker Hub - uses: docker/build-push-action@v2.5.0 - with: - build-args: | - mount='id=go_build_cache_mount,type=bind,source=/tmp/foo' - tags: iotaledger/goshimmer:develop - push: true - cache-from: type=local,src=/tmp/.buildx-cache - cache-to: type=local,mode=max,dest=/tmp/.buildx-cache-new +# - name: Publish to Docker Hub +# uses: docker/build-push-action@v2.5.0 +# with: +# build-args: | +# mount='id=go_build_cache_mount,type=bind,source=/tmp/foo' +# tags: iotaledger/goshimmer:develop +# push: true +# cache-from: type=local,src=/tmp/.buildx-cache +# cache-to: type=local,mode=max,dest=/tmp/.buildx-cache-new + + - name: Docker manual + run: docker buildx build --mount=id=go_build_cache_mount,type=bind,source=/tmp/foo --tag iotaledger/goshimmer:develop --cache-from type=local,src=/tmp/.buildx-cache --cache-to type=local,mode=max,dest=/tmp/.buildx-cache-new - # Temp fix # https://github.com/docker/build-push-action/issues/252 From 6d4f16edece30ecff26cf38ba15a64802d2bac44 Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 13:45:41 +0300 Subject: [PATCH 17/19] Revert "Try manual docker build" This reverts commit 302dcb54 --- .github/workflows/docker-develop.yml | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/.github/workflows/docker-develop.yml b/.github/workflows/docker-develop.yml index 5c77f7afac..c6016e0a37 100644 --- a/.github/workflows/docker-develop.yml +++ b/.github/workflows/docker-develop.yml @@ -37,18 +37,15 @@ jobs: username: '${{ secrets.IOTALEDGER_HUB_DOCKER_LOGIN }}' password: '${{ secrets.IOTALEDGER_HUB_DOCKER_PASSWORD }}' -# - name: Publish to Docker Hub -# uses: docker/build-push-action@v2.5.0 -# with: -# build-args: | -# mount='id=go_build_cache_mount,type=bind,source=/tmp/foo' -# tags: iotaledger/goshimmer:develop -# push: true -# cache-from: type=local,src=/tmp/.buildx-cache -# cache-to: type=local,mode=max,dest=/tmp/.buildx-cache-new - - - name: Docker manual - run: docker buildx build --mount=id=go_build_cache_mount,type=bind,source=/tmp/foo --tag iotaledger/goshimmer:develop --cache-from type=local,src=/tmp/.buildx-cache --cache-to type=local,mode=max,dest=/tmp/.buildx-cache-new + - name: Publish to Docker Hub + uses: docker/build-push-action@v2.5.0 + with: + build-args: | + mount='id=go_build_cache_mount,type=bind,source=/tmp/foo' + tags: iotaledger/goshimmer:develop + push: true + cache-from: type=local,src=/tmp/.buildx-cache + cache-to: type=local,mode=max,dest=/tmp/.buildx-cache-new - # Temp fix # https://github.com/docker/build-push-action/issues/252 From c5b1926664766e1742d05106437e56f4ba300f33 Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Tue, 8 Jun 2021 14:29:42 +0300 Subject: [PATCH 18/19] Don't pull pumba in integration tests other than autopeering --- .github/workflows/integration-tests.yml | 7 ------- Dockerfile | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index a062f35e1a..45ed66357c 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -61,7 +61,6 @@ jobs: - name: Pull additional Docker images run: | docker pull angelocapossele/drand:v1.1.4 - docker pull gaiaadm/pumba:0.7.2 docker pull gaiadocker/iproute2:latest - name: Run integration tests @@ -95,7 +94,6 @@ jobs: - name: Pull additional Docker images run: | docker pull angelocapossele/drand:v1.1.4 - docker pull gaiaadm/pumba:0.7.2 docker pull gaiadocker/iproute2:latest - name: Run integration tests @@ -130,7 +128,6 @@ jobs: - name: Pull additional Docker images run: | docker pull angelocapossele/drand:v1.1.4 - docker pull gaiaadm/pumba:0.7.2 docker pull gaiadocker/iproute2:latest - name: Run integration tests @@ -166,7 +163,6 @@ jobs: - name: Pull additional Docker images run: | docker pull angelocapossele/drand:v1.1.4 - docker pull gaiaadm/pumba:0.7.2 docker pull gaiadocker/iproute2:latest - name: Run integration tests @@ -202,7 +198,6 @@ jobs: - name: Pull additional Docker images run: | docker pull angelocapossele/drand:v1.1.4 - docker pull gaiaadm/pumba:0.7.2 docker pull gaiadocker/iproute2:latest - name: Run integration tests @@ -236,7 +231,6 @@ jobs: - name: Pull additional Docker images run: | docker pull angelocapossele/drand:v1.1.4 - docker pull gaiaadm/pumba:0.7.2 docker pull gaiadocker/iproute2:latest - name: Run integration tests @@ -270,7 +264,6 @@ jobs: - name: Pull additional Docker images run: | docker pull angelocapossele/drand:1.1.3 - docker pull gaiaadm/pumba:latest docker pull gaiadocker/iproute2:latest - name: Run integration tests diff --git a/Dockerfile b/Dockerfile index 3557c561a6..a2ef49bd7c 100644 --- a/Dockerfile +++ b/Dockerfile @@ -26,7 +26,7 @@ RUN go mod verify # 3. Build the binary # 4. Verify that goshimmer binary is statically linked RUN --mount=target=. \ - --mount=type=cache,id=go_build_cache_mount,target=/root/.cache/go-build \ + --mount=type=cache,target=/root/.cache/go-build \ GOOS=linux GOARCH=amd64 go build \ -tags="$BUILD_TAGS" \ -ldflags='-w -s -extldflags "-static"' \ From 101f366b45f5a0be99bdd1b0ddea18d3bc15d89b Mon Sep 17 00:00:00 2001 From: Georgy Savva Date: Wed, 9 Jun 2021 11:46:48 +0300 Subject: [PATCH 19/19] Clean up debug code --- .github/workflows/docker-develop.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/docker-develop.yml b/.github/workflows/docker-develop.yml index c6016e0a37..e493f21a09 100644 --- a/.github/workflows/docker-develop.yml +++ b/.github/workflows/docker-develop.yml @@ -6,9 +6,6 @@ on: - develop paths-ignore: - 'docs/**' - pull_request: - paths-ignore: - - 'docs/**' jobs: @@ -40,8 +37,6 @@ jobs: - name: Publish to Docker Hub uses: docker/build-push-action@v2.5.0 with: - build-args: | - mount='id=go_build_cache_mount,type=bind,source=/tmp/foo' tags: iotaledger/goshimmer:develop push: true cache-from: type=local,src=/tmp/.buildx-cache