Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Filters components refactor #811

Closed
iordanivanov opened this issue Apr 21, 2023 · 2 comments
Closed

[ENH] Filters components refactor #811

iordanivanov opened this issue Apr 21, 2023 · 2 comments
Labels
enhancement New feature or request odm low priority issues

Comments

@iordanivanov
Copy link
Contributor

Filters - continuous, multi-continuous, categorical, filter blocks (person/family) are in need of a refactor as there is a lot of logic that is prone to bugs. One example is the state restoring logic - as of writing this issue, the block component and the multi-continuous filter both attempt to restore state which can lead to issues. Also, currently we work under the assumption that only one multi-continuous filter can exist at a time - if there are more, the state restoring logic could break.

@iordanivanov iordanivanov added enhancement New feature or request odm low priority issues labels Apr 21, 2023
@joankosev
Copy link
Contributor

related #729

@IvoStefanov
Copy link
Contributor

Addressed/refactored in NGRX state transition.
But #729 is still a valid issue, the overall code of 3-5 components can be simplified with the implementation of different states for family and person filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request odm low priority issues
Projects
None yet
Development

No branches or pull requests

3 participants