Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder Profiler Data Collection Hooks #334

Open
kolanos opened this issue Jun 26, 2019 · 0 comments
Open

Reorder Profiler Data Collection Hooks #334

kolanos opened this issue Jun 26, 2019 · 0 comments

Comments

@kolanos
Copy link
Contributor

kolanos commented Jun 26, 2019

Right now the profiler plugin performs profiler data collection and upload during the pre-report hook. This poses a problem for the trace plugin as it does data collection in the same hook. Instead, the profiler plugin should perform it's data collection during post-invocation hooks and only append profiler data to the report in the pre-report hook. This will allow the trace plugin to consistently report profiler plugin performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant