Submit request header report for timed-out requests #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s we want to include Coercing comparison to lower-case to allow for case differentials Defining request.hostname from request.host if it's missing (as with Axios) Filtering/flattening recorded request headers early in case of a timeout Wrapping response handling in a conditional, if some aspect of the request means it should be dropped
kolanos
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating request key filtering and recording settings to allow headers we want to include
Coercing comparison to lower-case to allow for case differentials
Defining request.hostname from request.host if it's missing (as with Axios)
Filtering/flattening recorded request headers early in case of a timeout
Wrapping response handling in a conditional, if some aspect of the request means it should be dropped
Closes #41