Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Msgs ordered differently in different runs #1107

Closed
uriii3 opened this issue Sep 10, 2024 · 4 comments
Closed

Msgs ordered differently in different runs #1107

uriii3 opened this issue Sep 10, 2024 · 4 comments
Assignees

Comments

@uriii3
Copy link

uriii3 commented Sep 10, 2024

Version of compliance checker running:
IOOS compliance checker version 5.1.1

Describe the checker this affects:
IOOS

Attach a minimal CDL or NetCDF file which is able to reproduce the issue
It doesn't allow me to attach the file.nc so I compressed it.
output_1.nc.zip

To Reproduce:
Run several times compliance-checker --test=cf:1.7 output_1.nc -f json and check the order of the messages in the output.

Describe the issue below:
It is supposed to have 2 warning messages on 2.5 Variables saying something about valid_min and valid_max. The problem is that in some runs it appears first the min and then the max and in another runs it is the other way around.
To check the output operationally this is not the best to have, as the message as a whole is actually different (maybe) in different cases.

@benjwadams
Copy link
Contributor

Seems to apply to all checkers, not just JSON output.

@benjwadams
Copy link
Contributor

Issue is due to use of sets and their lack of consistent ordering. PR should address this.

@uriii3
Copy link
Author

uriii3 commented Sep 17, 2024

Uh, perfect then! Thank you very much!

@uriii3
Copy link
Author

uriii3 commented Oct 2, 2024

Do we know when will this be merged on to the main branch? Thanks a lot in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants