From 4caaae348662059e44e59ecbdc5ce7179cd27749 Mon Sep 17 00:00:00 2001 From: Ionut Cristian Bedregeanu Date: Fri, 7 Jan 2022 12:59:29 +0200 Subject: [PATCH] For #11499 - Update tracking protection icon state Update the state of tracking protection indicator even when is not displayed in order to avoid that scenario when the tracking protection became visible later but its state is not the last one --- .../components/browser/toolbar/display/DisplayToolbar.kt | 4 ---- docs/changelog.md | 3 +++ 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/components/browser/toolbar/src/main/java/mozilla/components/browser/toolbar/display/DisplayToolbar.kt b/components/browser/toolbar/src/main/java/mozilla/components/browser/toolbar/display/DisplayToolbar.kt index 38a4844dba2..b3b72fd92b9 100644 --- a/components/browser/toolbar/src/main/java/mozilla/components/browser/toolbar/display/DisplayToolbar.kt +++ b/components/browser/toolbar/src/main/java/mozilla/components/browser/toolbar/display/DisplayToolbar.kt @@ -511,10 +511,6 @@ class DisplayToolbar internal constructor( } internal fun setTrackingProtectionState(state: Toolbar.SiteTrackingProtection) { - if (!indicators.contains(Indicators.TRACKING_PROTECTION)) { - return - } - views.trackingProtectionIndicator.siteTrackingProtection = state updateSeparatorVisibility() } diff --git a/docs/changelog.md b/docs/changelog.md index 97944aea8ac..9f73fd68ccd 100644 --- a/docs/changelog.md +++ b/docs/changelog.md @@ -11,6 +11,9 @@ permalink: /changelog/ * [Gecko](https://github.com/mozilla-mobile/android-components/blob/main/buildSrc/src/main/java/Gecko.kt) * [Configuration](https://github.com/mozilla-mobile/android-components/blob/main/.config.yml) +* **browser-toolbar** + * 🚒 Bug fixed [issue #11499](https://github.com/mozilla-mobile/android-components/issues/11499) - Update tracking protection icon state even when is not displayed + * **browser-toolbar** * 🚒 Bug fixed [issue #11545](https://github.com/mozilla-mobile/android-components/issues/11545) - `clearColorFilter` doesn't work on Api 21, 22, so the default white filter remains set.Use `clearColorFilter` only when the version of API is bigger than 22