Support loading legacy .NET framework proj files #131
Conversation
This will open the doors to fixing this FSharpLint's bug: fsprojects/FSharpLint#336 (which is important for our FSharpLint v1.0 release milestone)
|
@baronfel can you please review? |
|
@baronfel @Krzysztof-Cieslak when you get a chance would it be possible to review this one please? For consumers it'll let us continue support the .net framework while making use of this library |
|
Hey folks, we're ok merging this to accommodate the FSharpLint use case, however neither @Krzysztof-Cieslak or myself use the old-style project support and therefore would like to request your support in helping maintain that area. Is that acceptable? |
|
@baronfel @Krzysztof-Cieslak Hey, thanks for the feedback. Sure, I will now subscribe to this repo and watch if any issues get filed related to this area |
|
Thank you! I'll merge them and make a new release then. |
|
@baronfel great news. Thank you. Much appreciated. |
|
It's taking a bit to get a green build on main after merging this - I worry that there's a problem. Not had time to track it down yet though. |
|
Hi, will be looking into this tomorrow. |
* Upgrade Ionide.ProjInfo to 0.58.0 (needed to bring the fix for parsing legacy projects, upstream PR: ionide/proj-info#131 , upstream commit: ionide/proj-info@3542cee ). * Upgrade FSharp.Compiler.Service to version 41 (needed because the new Ionide.ProjInfo version, depends on a higher version of F.C.S.). * Made changes to framework, rules and test framework code necessary to accomodate API changes in this version 41.x of FCS compared to version 40. Fixes #336
This will open the doors to fixing this FSharpLint's bug:
fsprojects/FSharpLint#336
(which is important for our FSharpLint v1.0 release milestone)