Repeated document formatting adds unnecessary new lines

[alarbada]

Describe the bug**

Steps to reproduce

Have the following setup:

.editorconfig

[*.fs]
indent_size=4
fsharp_max_array_or_list_width=20
fsharp_max_elmish_width=10
fsharp_single_argument_web_mode=true
fsharp_multi_line_lambda_closing_newline=true
fsharp_record_multiline_formatter=number_of_items
fsharp_max_record_number_of_items=1
fsharp_disable_elmish_syntax=false

Some random file, App.fs for example:

[<ReactComponent>]
let Dashboard () =
    Html.div [
        Html.div [
        ]
        Html.div [
            Html.text "hola muy buenas"
        ]
    ]

And just Ctrl + Shift + I multiple times

Link to sample reproduction

I don't think it is necessary

Expected behaviour

To be formated like this:

[<ReactComponent>]
let Dashboard () =
    Html.div [
        Html.div []
        Html.div [
            Html.text "hola muy buenas"
        ]
    ]

However, it gets formated like this:

[<ReactComponent>]
let Dashboard () =
    Html.div [
        Html.div [

        ]
        Html.div [
            Html.text "hola muy buenas"
        ]
    ]

Which I really don't mind, but the issue is whenever I reformat again the document without changing anything, the format output adds new unnecessary lines:

[<ReactComponent>]
let Dashboard () =
    Html.div [
        Html.div [


        ]
        Html.div [
            Html.text "hola muy buenas"
        ]

    ]

// And on, and on...

[<ReactComponent>]
let Dashboard () =
    Html.div [
        Html.div [




        ]
        Html.div [
            Html.text "hola muy buenas"
        ]



    ]

After some testing I found out that just passing an array with a null inside instead of an empty array solves the issue, but I'd expect to work both ways as expected

Machine info

• OS: Linux
• .NET SDK version: 5.0.103
• Ionide version: v5.3.2

[open-collective-bot]

Hey @not-rusty 👋,

Thank you for opening an issue. We will get back to you as
soon as we can. Also, check out our OpenCollective and consider
backing us.

https://opencollective.com/ionide

PS.: We offer backer support for all backers. Don't forget to add backer label when you start backing us 😄

[MangelMaxime]

Hello @not-rusty,

Ionide is using Fantomas for the formatting. I think you should open the issue there so @nojaf and others can take a look at it.

[nojaf]

Yes please, could you report an issue using https://fsprojects.github.io/fantomas-tools/#/fantomas/preview please?

[Krzysztof-Cieslak]

Closing as an upstream issue.