Fantomas Integration

[cannorin]

No description provided.

[Krzysztof-Cieslak]

This is handled as part of LSP, shouldn’t you get it for free?

[cannorin]

That's the point, I must try it out first.

[cannorin]

OK, formatting works out of the box through LSP, but we should be able to configure it through settings so some work would be needed

[cannorin]

It seems I have to set initializationOptions and LanguageClient-neovim can only specify JSON files to use as the parameter, but workspace/didChangeConfiguration can be used to do runtime configuration. I'll address it as a generic configuration support.

[cannorin]

Ah fsprojects/fantomas#354

[cannorin]

https://github.com/fsprojects/fantomas/blob/master/docs/Documentation.md#--config-path-to-file-or-folder

[Krzysztof-Cieslak]

Reading config is done on the FSAC side.

[cannorin]

So we don't have to modify the client, right?

[cannorin]

Actually no change was required (sorry for being late!)

[kumkee]

https://github.com/fsprojects/fantomas/blob/master/docs/Documentation.md#--config-path-to-file-or-folder

The link is broken.
I don't know how to configure the integration and your documentation doesn't mention the details either. Please reopen this issue.

[cannorin]

@kumkee Please see here: https://fsprojects.github.io/fantomas/docs/index.html

Once you have installed and configured Fantomas, FSAC should use Fantomas as the formatter.

(Currently, #66 is affecting Ionide-vim and it won't work with the latest FSAC, so please allow me to take some time to get everything ready to work for you.)

[kumkee]

(Currently, #66 is affecting Ionide-vim and it won't work with the latest FSAC, so please allow me to take some time to get everything ready to work for you.)

Then which is the latest version of FSAC that works with Ionide-vim?

Thank you, @cannorin.

[cannorin]

@kumkee v0.58.0 is working for me. v0.58.{1,2,3,4} might also work, but I haven't tested.

[kumkee]

@kumkee v0.58.0 is working for me. v0.58.{1,2,3,4} might also work, but I haven't tested.

What version of fantomas are you using? I've tried FSAC v0.58.0 with fantomas v 5.1.5. Formatting doesn't work.
For your information, my nvchad config for formatting keys is <space> + fm.

[cannorin]

@kumkee I'm not very familiar with nvchad, but make sure that <space> + fm is indeed calling LSP's format command (like vim.lsp.buf.format). If you don't see any kind of LSP-related error message, there is a good chance that the format command is not called at all.

[kumkee]

If you don't see any kind of LSP-related error message, there is a good chance that the format command is not called at all.

What if the same key combo works in all other languages?

[cannorin]

It seems that you are using null-ls for formatting and it doesn't contain Fantomas?

https://github.com/kumkee/nvchad_config/blob/main/configs/null-ls.lua#L7C24-L34

[kumkee]

It seems that you are using null-ls for formatting and it doesn't contain Fantomas?

https://github.com/kumkee/nvchad_config/blob/main/configs/null-ls.lua#L7C24-L34

It's funny that you asked. I've opened a feature request issue in null-ls. No one has responded. Please have a look.

[cannorin]

Since Ionide-vim delegates all the LSP functionalities (including formatting) to FSAC (and thus Fantomas), I guess Ionide-vim cannot help you solving the problem.

I think you can either

1. configure nvim-lspconfig to call the format command (as in https://github.com/neovim/nvim-lspconfig#suggested-configuration), or
2. try to make null-ls work with Fantomas.