Improve detection and replacement logic for 'remove binding' codefix #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
force-pushed
the
fix-remove-binding-codefix
branch
from
887cc7a to
b7a1e62
Compare
|
Reported upstream with links, so we can merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #811
The logic here is to dive into the SynPat of a Binding first to see if we can find a more specific pattern replacement instead of the entire binding. If we can, then the replacement logic (tokens to look for, etc) is slightly different for an entire pattern, but structurally quite similar.
I added tests for several cases, and I do think this is a better way to go. We should consider upstreaming this as well.