Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly better project loading error messages #1234

Merged

Conversation

TheAngryByrd
Copy link
Member

  • Centralizes and logs Cancellation of LSP endpoints as Info messages
  • Converts some types from Options to Results for better errors
  • Changed messages to inform the user the projects might not be loaded (yes we still need to fix the auto restore but that's a more work)
  • Refactored the selectProject to be an interface rather than a FSharpFunc. Makes it easier to swap later. Adaptive requires comparisons and FSharpFuncs aren't comparable.

@baronfel
Copy link
Contributor

This should reduce a lot of noise :) Thanks @TheAngryByrd!

@baronfel baronfel merged commit de453f7 into ionide:main Feb 16, 2024
14 checks passed
@TheAngryByrd TheAngryByrd changed the title Slightly better loading error messages Slightly better project loading error messages Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants