Fix tooltip errorhandling #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jimmy Byrd <[email protected]> * Replaces spurious hover errors with log messages * Similar treatment for certain helper functions * Basic test for pipeline hints (needs more coverage)
TheAngryByrd
reviewed
Nov 6, 2023
| file.Source | ||
| |> tryGetLineStr pos | ||
| |> Result.mapError ErrorMsgUtils.formatLineLookErr | ||
| //TODO ⮝⮝⮝ good candidate for better error model -- review! |
pblasucci
force-pushed
the
amplifying-fsharp-errors
branch
from
6e454c0 to
683625a
Compare
TheAngryByrd
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Thanks a ton @pblasucci!
@1eyewonder I'm gonna merge this one. Probably want to rebase your branch.
|
Yep I'll get it on later this evening 😄 |
TheAngryByrd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Jimmy Byrd [email protected]
WHAT
🤖 Generated by Copilot at 683625a
This pull request refactors and improves some parts of the FsAutoComplete core and LSP server modules, especially related to error handling, type conversions, and option types. It also adds a new test case for the inline hints feature and cleans up some whitespace in the test project file. The main files affected are
Commands.fs,ParseAndCheckResults.fs,AdaptiveFSharpLspServer.fs,Common.fs,InlineHintsTests.fs, andFsAutoComplete.Tests.Lsp.fsproj.🤖 Generated by Copilot at 683625a
🛠️🚀🧹
WHY
Because proper modelling and handling of various program states is important (and the hack session was fun!)
HOW
🤖 Generated by Copilot at 683625a
Commands.fsandAdaptiveServerState.fs(link, link, link)Commands.fs(link, link)InlineHintsTests.fs, which defines a test case for the inline hints feature of the server (link, link)FsAutoComplete.Tests.Lsp.fsproj(link, link)