Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port over 'add explicit type' refactoring from dotnet/fsharp #806

Closed
baronfel opened this issue Jun 25, 2021 · 2 comments · Fixed by #807
Closed

Port over 'add explicit type' refactoring from dotnet/fsharp #806

baronfel opened this issue Jun 25, 2021 · 2 comments · Fixed by #807
Labels
enhancement help wanted type:refactor Work that adds a refactoring fix to the product

Comments

@baronfel
Copy link
Contributor

Source is here, it looks fairly straightforward to replicate.
@baronfel baronfel added enhancement help wanted type:refactor Work that adds a refactoring fix to the product labels Jun 25, 2021
@baronfel
Copy link
Contributor Author

I think I want to break out refactorings into a separate folder from where CodeFixes are now (purely for organizational/bookkeeping purposes), so it might be good to do that as part of this work.

@baronfel
Copy link
Contributor Author

This will actually be blocked until the FCS 40 upgrade (and potentially after) because it depends on properties that were added to FSharpMemberOrFunctionOrValue. Depending on if those have landed in the public FCS we may be blocked for a bit.

@baronfel baronfel mentioned this issue Jun 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted type:refactor Work that adds a refactoring fix to the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(mostly) implement explicit type annotation codefix baronfel/FsAutoComplete
1 participant
@baronfel