From 065e3e9937104f6ec03e594adf762002616353df Mon Sep 17 00:00:00 2001 From: Daniel Imhoff Date: Thu, 18 Jan 2018 11:36:40 -0600 Subject: [PATCH] remove problematic rules MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit @brandyscarney says: > here are the ones I ran into issues with in the framework: > > * `no-unnecessary-type-assertion` is throwing errors when we cast as an HTMLElement - which is necessary because otherwise it queries as an `Element` and throws errors that the properties don’t exist, this is a bug in TS: https://github.com/palantir/tslint/issues/3540 > * `prefer-for-of` is throwing errors on node lists which is also a bug: https://github.com/palantir/tslint/issues/2927 > * `no-conditional-assignment` is used in DOM controller --- tslint.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/tslint.js b/tslint.js index cd2988f..5a0ec86 100644 --- a/tslint.js +++ b/tslint.js @@ -15,7 +15,6 @@ module.exports = { "jsdoc-format": [true, "check-multiline-start"], "linebreak-style": [true, "LF"], "new-parens": true, - "no-conditional-assignment": true, "no-debugger": true, "no-duplicate-super": true, "no-duplicate-switch-case": true, @@ -32,7 +31,6 @@ module.exports = { "no-string-throw": true, "no-switch-case-fall-through": true, "no-trailing-whitespace": true, - "no-unnecessary-type-assertion": true, "no-unsafe-finally": true, "no-unused-variable": true, "no-var-keyword": true, @@ -53,7 +51,6 @@ module.exports = { }, "prefer-conditional-expression": true, "prefer-const": true, - "prefer-for-of": true, "quotemark": {"options": ["single"]}, "radix": true, "semicolon": {"options": ["always"]},