Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop 'experimentalScopedSlotChanges' warning msg on startup #6068

Conversation

johnjenkins
Copy link
Contributor

@johnjenkins johnjenkins commented Nov 28, 2024

What is the current behavior?

Given stencil.config options

extras: {
    experimentalSlotFixes: true,
  },

a warning shows:

If the 'experimentalSlotFixes' flag is enabled it will override any slot fix flags which are disabled. In
particular, the following currently-disabled flags will be ignored: experimentalScopedSlotChanges. Please
update your Stencil config accordingly.

This was introduced in #6055 due to experimentalScopedSlotChanges not being explicitly set (and defaulting to false) when experimentalSlotFixes is set.

GitHub Issue Number: N/A

What is the new behavior?

No warnings

Documentation

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added this pull request to the merge queue Dec 6, 2024
Merged via the queue into ionic-team:main with commit d362700 Dec 6, 2024
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants