fix(runtime): merge styles within ShadowRoot into a single node #6014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-bromann
changed the title
christian-bromann
force-pushed
the
cb/merge-styles-in-shadow-root
branch
from
2808da7
to
cd53ef7
Compare
tanner-reits
approved these changes
Oct 8, 2024
christian-bromann
force-pushed
the
cb/merge-styles-in-shadow-root
branch
from
4895353
to
5d9ee79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
When Stencil serializes a scoped component within a shadow component, it used to create different style nodes for different components used within the shadow root. While this is technically fine, it creates confusion in the runtime as the index of nodes changes.
What is the new behavior?
Have Stencil just render a single style tag per shadow root.
Documentation
Does this introduce a breaking change?
Testing
Added e2e tests for this.
Other information
n/a