-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime): scoped slot append/prepend correct order after interaction #5970
fix(runtime): scoped slot append/prepend correct order after interaction #5970
Conversation
… properly with slot relocation algo ionic-team#5969
to summarize, I added the others ( |
@yigityuce do you think we can add a unit test for this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yigityuce Changes look good! Only request would be to add a test like @christian-bromann suggested. You could probably add a Webdriver test to our existing test suite for these methods here. Let me know if you have any questions!
hey @christian-bromann & @tanner-reits tests are added as a separate test file since to reproduce the issue, I need to remove the default slot wrapper and I didn't want to break the existing test case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yigityuce Thanks! Everything looks good. I'll get this merged and try to get a release out this week!
Released in Stencil |
What is the current behavior?
GitHub Issue Number: #5969
What is the new behavior?
Documentation
Does this introduce a breaking change?
Testing
Other information