Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(declarations): add missing event handler types #5964

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

christian-bromann
Copy link
Member

What is the current behavior?

GitHub Issue Number: fixes #5963

What is the new behavior?

Added missing event handlers to the public runtime. I am not sure if onBeforeToggleCapture or onToggleCapture are a thing but it seems it makes sense to follow the existing pattern. Happy to remove these.

Documentation

Does this introduce a breaking change?

  • Yes
  • No

Testing

n/a

Other information

n/a

@christian-bromann christian-bromann merged commit 6ef1334 into main Aug 30, 2024
88 checks passed
@christian-bromann christian-bromann deleted the cb/missing-events branch August 30, 2024 16:14
@christian-bromann
Copy link
Member Author

Released in Stencil v4.22.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Missing "beforetoggle" and "toggle" events on HTMLElement
2 participants