fix(runtime): have fallback for style setting #5948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
The Ionic Framework nightly build is failing. After some investigations it seems that the page had a missing style tag in the header which caused the component to be rendered without padding:
> Left side is the working version, right side is the Playwright trace
I don't know why the style tag with the styles for
ion-listisn't rendered only in CI. I have to assume that it has to do with Playwright behaving funky here. I can't reproduce it locally at all.What is the new behavior?
Added an
elsestatement in cases none of the previous if statement match which should never happen but may have happened here. Worth a try.Documentation
Does this introduce a breaking change?
Testing
n/a
Other information
n/a