fix(runtime): add missing intermediate parents scope ids to the elements #5775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Path | Location | Error | Message |
|---|---|---|---|
| src/runtime/vdom/vdom-render.ts | (200, 39) | TS2345 | |
| src/runtime/vdom/vdom-render.ts | (231, 20) | TS2345 | |
| src/runtime/vdom/vdom-render.ts | (284, 29) | TS2345 | |
| src/runtime/vdom/vdom-render.ts | (546, 11) | TS2322 | |
| src/runtime/vdom/vdom-render.ts | (563, 24) | TS2345 | |
| src/runtime/vdom/vdom-render.ts | (687, 22) | TS2345 | |
| src/runtime/vdom/vdom-render.ts | (698, 5) | TS18047 | |
| src/runtime/vdom/vdom-render.ts | (756, 65) | TS18047 | |
| src/runtime/vdom/vdom-render.ts | (794, 31) | TS2322 | |
| src/runtime/vdom/vdom-render.ts | (821, 41) | TS2345 | |
| src/runtime/vdom/vdom-render.ts | (849, 72) | TS2345 | |
| src/runtime/vdom/vdom-render.ts | (928, 50) | TS2345 | |
| src/runtime/vdom/vdom-render.ts | (942, 7) | TS2345 | |
| src/runtime/vdom/vdom-render.ts | (944, 23) | TS2345 | |
| src/runtime/vdom/vdom-render.ts | (1004, 57) | TS2345 | |
| src/runtime/vdom/vdom-render.ts | (1034, 53) | TS2538 | |
| src/runtime/vdom/vdom-render.ts | (1060, 3) | TS2322 | |
| src/runtime/vdom/vdom-render.ts | (1066, 5) | TS2322 | |
| src/runtime/vdom/vdom-render.ts | (1100, 24) | TS2345 | |
| src/runtime/vdom/vdom-render.ts | (1163, 42) | TS2531 | |
| src/runtime/vdom/vdom-render.ts | (1170, 28) | TS2345 |
reports and statistics
Our most error-prone files
| Path | Error Count |
|---|---|
| src/dev-server/index.ts | 37 |
| src/dev-server/server-process.ts | 32 |
| src/compiler/prerender/prerender-main.ts | 22 |
| src/runtime/vdom/vdom-render.ts | 21 |
| src/runtime/client-hydrate.ts | 20 |
| src/screenshot/connector-base.ts | 19 |
| src/testing/puppeteer/puppeteer-element.ts | 19 |
| src/dev-server/request-handler.ts | 15 |
| src/compiler/prerender/prerender-optimize.ts | 14 |
| src/compiler/sys/stencil-sys.ts | 14 |
| src/runtime/connected-callback.ts | 14 |
| src/sys/node/node-sys.ts | 14 |
| src/compiler/prerender/prerender-queue.ts | 13 |
| src/compiler/sys/in-memory-fs.ts | 13 |
| src/runtime/set-value.ts | 13 |
| src/compiler/output-targets/output-www.ts | 12 |
| src/compiler/transformers/test/parse-vdom.spec.ts | 12 |
| src/compiler/transformers/transform-utils.ts | 12 |
| src/mock-doc/test/attribute.spec.ts | 12 |
| src/compiler/build/compiler-ctx.ts | 11 |
Our most common errors
| Typescript Error Code | Count |
|---|---|
| TS2322 | 358 |
| TS2345 | 345 |
| TS18048 | 201 |
| TS18047 | 77 |
| TS2722 | 37 |
| TS2532 | 24 |
| TS2531 | 19 |
| TS2454 | 14 |
| TS2790 | 11 |
| TS2352 | 9 |
| TS2769 | 8 |
| TS2416 | 7 |
| TS2538 | 4 |
| TS2493 | 3 |
| TS18046 | 2 |
| TS2684 | 1 |
| TS2430 | 1 |
Unused exports report
There are 15 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!
Unused exports
| File | Line | Identifier |
|---|---|---|
| src/runtime/bootstrap-lazy.ts | 21 | setNonce |
| src/screenshot/screenshot-fs.ts | 18 | readScreenshotData |
| src/testing/testing-utils.ts | 198 | withSilentWarn |
| src/utils/index.ts | 145 | CUSTOM |
| src/utils/index.ts | 245 | NODE_TYPES |
| src/utils/index.ts | 269 | normalize |
| src/utils/index.ts | 7 | escapeRegExpSpecialCharacters |
| src/compiler/app-core/app-data.ts | 25 | BUILD |
| src/compiler/app-core/app-data.ts | 116 | Env |
| src/compiler/app-core/app-data.ts | 118 | NAMESPACE |
| src/compiler/fs-watch/fs-watch-rebuild.ts | 123 | updateCacheFromRebuild |
| src/compiler/types/validate-primary-package-output-target.ts | 61 | satisfies |
| src/compiler/types/validate-primary-package-output-target.ts | 61 | Record |
| src/testing/puppeteer/puppeteer-declarations.ts | 485 | WaitForEventOptions |
| src/compiler/sys/fetch/write-fetch-success.ts | 7 | writeFetchSuccessSync |
PR built and packed!Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/9170173407/artifacts/1521832750 If your browser saves files to |
|
@yigityuce thanks for the PR. I wonder if we can have a WDIO component test for this 🤔 |
@christian-bromann added test cases 🧪 |
christian-bromann
approved these changes
May 20, 2024
|
@christian-bromann & @alicewriteswrongs test cases are updated to remove duplicated await statement |
|
thanks @christian-bromann we are waiting someone else to approve too right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
GitHub Issue Number: #5774
What is the new behavior?
Documentation
Does this introduce a breaking change?
Testing
Other information