fix(runtime): add root scope id to the user provided nested children as classname

[yigityuce]

What is the current behavior?

GitHub Issue Number: #5749

What is the new behavior?

Documentation

Does this introduce a breaking change?

• Yes
• No

Testing

Other information

[github-actions]

--strictNullChecks error report

Typechecking with --strictNullChecks resulted in 1125 errors on this branch.

Unfortunately, it looks like that's an increase of 6 over main 😞.

Violations Not on `main` (may be more than the count above)

Path	Location	Error	Message
src/runtime/connected-callback.ts	(17, 21)	TS18048
src/runtime/connected-callback.ts	(22, 34)	TS2345
src/runtime/connected-callback.ts	(25, 11)	TS18048
src/runtime/connected-callback.ts	(27, 7)	TS18048
src/runtime/connected-callback.ts	(31, 9)	TS2322
src/runtime/connected-callback.ts	(35, 51)	TS2345
src/runtime/connected-callback.ts	(39, 67)	TS2345
src/runtime/connected-callback.ts	(43, 36)	TS2454
src/runtime/connected-callback.ts	(75, 30)	TS2345
src/runtime/connected-callback.ts	(75, 40)	TS18048
src/runtime/connected-callback.ts	(98, 49)	TS2345
src/runtime/connected-callback.ts	(100, 34)	TS2345
src/runtime/connected-callback.ts	(107, 34)	TS2345
src/runtime/connected-callback.ts	(132, 36)	TS2345
src/runtime/dom-extras.ts	(88, 41)	TS2345
src/runtime/dom-extras.ts	(148, 10)	TS2532
src/runtime/dom-extras.ts	(153, 29)	TS2345
src/runtime/dom-extras.ts	(241, 7)	TS2322
src/runtime/dom-extras.ts	(261, 64)	TS2345
src/runtime/dom-extras.ts	(313, 26)	TS2345
src/runtime/dom-extras.ts	(391, 11)	TS2532
src/runtime/dom-extras.ts	(446, 5)	TS2322
src/runtime/vdom/vdom-annotations.ts	(62, 26)	TS2345
src/runtime/vdom/vdom-annotations.ts	(224, 20)	TS2345
src/runtime/vdom/vdom-render.ts	(196, 39)	TS2345
src/runtime/vdom/vdom-render.ts	(227, 20)	TS2345
src/runtime/vdom/vdom-render.ts	(280, 29)	TS2345
src/runtime/vdom/vdom-render.ts	(542, 11)	TS2322
src/runtime/vdom/vdom-render.ts	(559, 24)	TS2345
src/runtime/vdom/vdom-render.ts	(683, 22)	TS2345
src/runtime/vdom/vdom-render.ts	(694, 5)	TS18047
src/runtime/vdom/vdom-render.ts	(752, 65)	TS18047
src/runtime/vdom/vdom-render.ts	(790, 31)	TS2322
src/runtime/vdom/vdom-render.ts	(817, 41)	TS2345
src/runtime/vdom/vdom-render.ts	(845, 72)	TS2345
src/runtime/vdom/vdom-render.ts	(924, 50)	TS2345
src/runtime/vdom/vdom-render.ts	(935, 83)	TS2345
src/runtime/vdom/vdom-render.ts	(985, 57)	TS2345
src/runtime/vdom/vdom-render.ts	(1015, 53)	TS2538
src/runtime/vdom/vdom-render.ts	(1041, 3)	TS2322
src/runtime/vdom/vdom-render.ts	(1047, 5)	TS2322
src/runtime/vdom/vdom-render.ts	(1081, 24)	TS2345
src/runtime/vdom/vdom-render.ts	(1144, 42)	TS2531
src/runtime/vdom/vdom-render.ts	(1151, 28)	TS2345

reports and statistics

Our most error-prone files

Path	Error Count
src/dev-server/index.ts	37
src/dev-server/server-process.ts	32
src/compiler/prerender/prerender-main.ts	22
src/runtime/client-hydrate.ts	20
src/runtime/vdom/vdom-render.ts	20
src/screenshot/connector-base.ts	19
src/testing/puppeteer/puppeteer-element.ts	19
src/dev-server/request-handler.ts	15
src/compiler/prerender/prerender-optimize.ts	14
src/compiler/sys/stencil-sys.ts	14
src/runtime/connected-callback.ts	14
src/sys/node/node-sys.ts	14
src/compiler/prerender/prerender-queue.ts	13
src/compiler/sys/in-memory-fs.ts	13
src/runtime/set-value.ts	13
src/compiler/output-targets/output-www.ts	12
src/compiler/transformers/test/parse-vdom.spec.ts	12
src/compiler/transformers/transform-utils.ts	12
src/mock-doc/test/attribute.spec.ts	12
src/compiler/build/compiler-ctx.ts	11

Our most common errors

Typescript Error Code	Count
TS2322	360
TS2345	345
TS18048	201
TS18047	77
TS2722	37
TS2532	24
TS2531	19
TS2454	14
TS2790	11
TS2352	9
TS2769	8
TS2416	7
TS2538	6
TS2493	3
TS18046	2
TS2684	1
TS2430	1

Unused exports report

There are 15 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!

Unused exports

File	Line	Identifier
src/runtime/bootstrap-lazy.ts	21	setNonce
src/screenshot/screenshot-fs.ts	18	readScreenshotData
src/testing/testing-utils.ts	198	withSilentWarn
src/utils/index.ts	145	CUSTOM
src/utils/index.ts	245	NODE_TYPES
src/utils/index.ts	269	normalize
src/utils/index.ts	7	escapeRegExpSpecialCharacters
src/compiler/app-core/app-data.ts	25	BUILD
src/compiler/app-core/app-data.ts	116	Env
src/compiler/app-core/app-data.ts	118	NAMESPACE
src/compiler/fs-watch/fs-watch-rebuild.ts	123	updateCacheFromRebuild
src/compiler/types/validate-primary-package-output-target.ts	61	satisfies
src/compiler/types/validate-primary-package-output-target.ts	61	Record
src/testing/puppeteer/puppeteer-declarations.ts	485	WaitForEventOptions
src/compiler/sys/fetch/write-fetch-success.ts	7	writeFetchSuccessSync

[github-actions]

PR built and packed!

Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/9044514431/artifacts/1493711522

If your browser saves files to ~/Downloads you can install it like so:

unzip -d ~/Downloads ~/Downloads/stencil-core-4.18.0-dev.1715439597.6001921.tgz.zip && npm install ~/Downloads/stencil-core-4.18.0-dev.1715439597.6001921.tgz

[christian-bromann]

There are some places where we don't use the patched insertBefore version:

• https://github.com/yigityuce/stencil/blob/f4344293aca323ad38567621d96d6bf78f861717/src/runtime/dom-extras.ts#L356
• https://github.com/yigityuce/stencil/blob/f4344293aca323ad38567621d96d6bf78f861717/src/runtime/vdom/vdom-annotations.ts#L223
• https://github.com/yigityuce/stencil/blob/f4344293aca323ad38567621d96d6bf78f861717/src/runtime/connected-callback.ts#L131

I wonder if we should stay consistent with this patch and apply it in there too.

Otherwise the code lgtm, I was able to reproduce the problem given the reproducible example and verified that the fix actually addresses the problem.

[christian-bromann]

LGTM 👍

I will let someone from the @ionic-team/stencil team take another look at it.