Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: globalStyle SCSS dependency not rebuilding #5287

Closed
3 tasks done
silvertech-daniel opened this issue Jan 22, 2024 · 6 comments
Closed
3 tasks done

bug: globalStyle SCSS dependency not rebuilding #5287

silvertech-daniel opened this issue Jan 22, 2024 · 6 comments
Assignees

Comments

@silvertech-daniel
Copy link

Prerequisites

Stencil Version

4.11.0

Current Behavior

#5244 (comment)

globalStyle dependency .scss files are being noticed (it triggers a rebuild) but not actually including the changes unless I touch the globalStyle file.


Another is that a component without a styleUrl will be rebuilt when unrelated styles are updated.

This one I could not find a way to minimally replicate but I did observe it in a large closed-source project

Expected Behavior

Updating any dependency is treated the same as updating the dependent file

System Info

System: node 19.6.0
    Platform: windows (10.0.19045)
   CPU Model: Intel(R) Core(TM) i5-7300HQ CPU @ 2.50GHz (4 cpus)
    Compiler: C:\Users\daniel.ethridge\Desktop\repos\stencil-bug\node_modules\@stencil\core\compiler\stencil.js
       Build: 1705946070
     Stencil: 4.11.0
  TypeScript: 5.3.3
      Rollup: 2.56.3
      Parse5: 7.1.2
      jQuery: 4.0.0-pre
      Terser: 5.27.0

Steps to Reproduce

Update ./src/global/_x.scss and notice that it does not update until you touch ./src/global/_global.scss as well.

Code Reproduction URL

https://github.com/silvertech-daniel/stencil-bug

Additional Information

No response

@christian-bromann
Copy link
Member

@silvertech-daniel thanks for providing the reproducible example. Unfortunately I am not able to really reproduce this. After starting the dev server via npm run dev I can go to ./src/global/_x.scss and successfully change the file and get an update:

repro-failed

Can you maybe help me understand what I need to do to repro this?

@silvertech-daniel
Copy link
Author

it's probably something that only happens on windows. Stencil says that a rebuild gets triggered even when I edit an unrelated file like README.md

@christian-bromann
Copy link
Member

Oh, I think this has been fixed in a different package which hasn't been released yet, see ionic-team/stencil-sass#459

@christian-bromann
Copy link
Member

@silvertech-daniel we have cut a dev release of our sass plugin, can you run npm i @stencil/[email protected] and see if this resolves the issue?

@silvertech-daniel
Copy link
Author

@christian-bromann that works perfectly — lmk when that gets released!

@rwaskiewicz
Copy link
Contributor

The fix for this issue has been included in today's @stencil/sass release (v3.0.9) (Changelog). As a result, I'm going to close this issue out. Should this bug reappear, please feel free to open a new issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants