Fix mock-doc Node.contains implementation #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Node.contains` method should return `true` if the passed node is the parent/context node. [The wording in the spec](https://dom.spec.whatwg.org/#dom-node-contains) is that it should return `true` if the passed node is an "inclusive descendant", which differs from a regular "descendant" in that it includes the object itself (not just the child nodes).
splitinfinities
added
the
Resolution: Refine
rwaskiewicz
suggested changes
Dec 3, 2021
rwaskiewicz
added
the
Awaiting Reply
Co-authored-by: Ryan Waskiewicz <[email protected]>
rwaskiewicz
approved these changes
Dec 3, 2021
|
Merged! Thanks again! 🙏 |
ionitron-bot
bot
added
Reply Received
and removed
Awaiting Reply
rwaskiewicz
added
Resolution: Shipped
and removed
Resolution: Refine
|
This fix has been included in the v2.12.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run test.karma.prod) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
GitHub Issue Number: #3149
What is the new behavior?
The
Node.containsmethod should returntrueif the passed node is the parent/context node. The wording in the spec is that it should returntrueif the passed node is an "inclusive descendant", which differs from a regular "descendant" in that it includes the object itself (not just the child nodes).Does this introduce a breaking change?
Testing
Other information