fix(dev-mode) always add dist-types #2402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the help of @simonhaenisch I could find the reason why #2349 is happening.
It is because here
stencil/src/compiler/config/outputs/validate-dist.ts
Line 47 in 4c70fdd
the
buildDist
isfalse
and the output targetDIST_TYPES
is not added in dev-mode. It is however needed later on.This causes this condition to return false:
stencil/src/compiler/transpile/ts-config.ts
Line 8 in 63595bc
and
declaration
becomesfalse
- which is not allowed in combination withcomposite: true
.I first tried to tackle it via this line by removing the
devMode
condition but it seems too related to other (global) decisions you've made maybe:stencil/src/compiler/config/validate-config.ts
Line 52 in 253894d
So my solution is to always add the output target
DIST_TYPES
no matter the mode (dev or prod).This is a huge blocker for us - would love to find a solution!