Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev-mode) always add dist-types #2402

Merged

Conversation

bitflower
Copy link
Contributor

With the help of @simonhaenisch I could find the reason why #2349 is happening.

It is because here

the buildDist is false and the output target DIST_TYPES is not added in dev-mode. It is however needed later on.

This causes this condition to return false:

declaration: config.outputTargets.some(isOutputTargetDistTypes),

and declaration becomes false - which is not allowed in combination with composite: true.

I first tried to tackle it via this line by removing the devMode condition but it seems too related to other (global) decisions you've made maybe:

setBooleanConfig(config, 'buildDist', 'esm', !config.devMode || config.buildEs5);

So my solution is to always add the output target DIST_TYPES no matter the mode (dev or prod).

This is a huge blocker for us - would love to find a solution!

@manucorporat manucorporat merged commit f523461 into ionic-team:master May 6, 2020
@manucorporat
Copy link
Contributor

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants