External lib included causes duplicate TS helpers and runtime error

[MrAntix]

Stencil version:

 @stencil/[email protected]

I'm submitting a:

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:

Rxjs gets included in built component this includes a "function __external"
TS helper var _external is also emitted and they clash causing runtime error

Expected behavior:

Steps to reproduce:

1. yarn build the lib
2. yarn build the components
3. navigate to ./components/dist/esm/es5/build/my-component.js - file contains duplicates described

I made a repro repo and included the built files
https://github.com/MrAntix/stencil-ts-duplicate-helper/blob/master/components/dist/esm/es5/build/my-component.js
https://github.com/MrAntix/stencil-ts-duplicate-helper

Related code:

see image lines 1 and 36

Other information:

[MrAntix]

Workaround

stencil.config.ts

import { Config } from '@stencil/core';
import postprocess from 'rollup-plugin-postprocess';

export const config: Config = {
  namespace: 'muse-ui-dugout-components',
  outputTargets: [
    {
      type: 'dist'
    }
  ],
  plugins: [
    postprocess([
      [
        `function __extends\\(`,
        'function xx__extends ('
      ]
    ])
  ],
  globalScript: 'src/global'
};

this doesn't work after all

the first var __extends is not always added to the esm file

[jthoms1]

@manucorporat I believe you were looking into this.

[MrAntix]

@manucorporat

If we add importHelpers: true to the transpile options for the es5 worker, the code produced works fine
But when the global script is wrapped the import ends up inside the wrapper
I did this to move it back out

e298edb

If this approach is ok, and you want me too, I can tidy test and PR a new branch based on current master.

[MrAntix]

FYI using the version 14.0.0-1 works fine, however, the code produced causes the angular compiler to fall over

see angular/angular-cli#12568

[adamdbradley]

The original issue should be fixed with the latest build. Thanks for the report.