This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
Add advertising id collection support (to $cordovaGoogleAnalytics) #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the avaliabilty of enable the Advertising ID Collection using the new function added to the plugin (in danwilson/google-analytics-plugin#252)
Yes, shit happen.
This was referenced Jul 22, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the avaliabilty of enable the Google Analytics Advertising ID Collection using the new function added to the plugin (in danwilson/google-analytics-plugin#252). This allows to collect demographics and interest reports (as described in https://support.google.com/analytics/answer/2444872)
It was added to the plugin two days ago, after a lot of requests from users. I think that would be amazing have that feature available in ng-cordova asap, so I did it.
p.d.: This is my first contribution here, so if there is something I have forgotten, please, tell me to do it!