Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Vue - Tabs - 5.9.2 - Double click on TabButton breaks tabs-routing #24353

Closed
4 of 6 tasks
Predarion opened this issue Dec 9, 2021 · 6 comments · Fixed by #24355
Closed
4 of 6 tasks

bug: Vue - Tabs - 5.9.2 - Double click on TabButton breaks tabs-routing #24353

Predarion opened this issue Dec 9, 2021 · 6 comments · Fixed by #24355
Assignees
Labels
package: vue @ionic/vue package type: bug a confirmed bug report

Comments

@Predarion
Copy link

Predarion commented Dec 9, 2021

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

When double clicking a Tab, routing to other Tabs when pressing their TabButton is not working anymore. See:

Screen.Recording.2021-12-09.at.08.32.03.mov

Expected Behavior

Expected to be routed to the Tab when pressing on the Tab2-TabButton (Step 4).

Steps to Reproduce

  1. Click on Tab2 --> Routes to Tab2
  2. Click on Tab1 --> Routes to Tab1
  3. Click Tab1 again --> nothing happens (we already are on the correct tab)
  4. Click Tab2 --> route changes but we are not routed to Tab2

Reprocution code is simply a Tabs starter project generated with:

ionic start ionic-vue-tabs-double-tab-bug tabs --type vue

and changed these two lines in the package.json to:

    "@ionic/vue": "5.9.2",
    "@ionic/vue-router": "5.9.2",

Code Reproduction URL

https://github.com/Predarion/ionic-vue-tabs-double-tab-bug

Ionic Info

[WARN] Error loading @capacitor/ios package.json: Error: Cannot find module '@capacitor/ios/package'

   Require stack:
   - /usr/local/lib/node_modules/@ionic/cli/lib/project/index.js
   - /usr/local/lib/node_modules/@ionic/cli/lib/index.js
   - /usr/local/lib/node_modules/@ionic/cli/index.js
   - /usr/local/lib/node_modules/@ionic/cli/bin/ionic

[WARN] Error loading @capacitor/android package.json: Error: Cannot find module '@capacitor/android/package'

   Require stack:
   - /usr/local/lib/node_modules/@ionic/cli/lib/project/index.js
   - /usr/local/lib/node_modules/@ionic/cli/lib/index.js
   - /usr/local/lib/node_modules/@ionic/cli/index.js
   - /usr/local/lib/node_modules/@ionic/cli/bin/ionic

Ionic:

Ionic CLI : 6.18.1 (/usr/local/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/vue 5.9.2

Capacitor:

Capacitor CLI : 3.3.3
@capacitor/android : not installed
@capacitor/core : 3.3.3
@capacitor/ios : not installed

Utility:

cordova-res : not installed globally
native-run : 1.5.0

System:

NodeJS : v16.13.0 (/usr/local/bin/node)
npm : 8.1.0
OS : macOS Big Sur

Additional Information

This bug might be introduced with the changes from

as this behavior does not occur with version 5.9.1, but does occur with version 5.9.2 and the dev build of aboves issue:

npm install @ionic/[email protected] @ionic/[email protected]
@ionitron-bot ionitron-bot bot added the triage label Dec 9, 2021
@Predarion
Copy link
Author

@liamdebeasi this issue seems quite critical to me again.

@liamdebeasi liamdebeasi self-assigned this Dec 9, 2021
@liamdebeasi liamdebeasi added package: vue @ionic/vue package type: bug a confirmed bug report labels Dec 9, 2021
@ionitron-bot ionitron-bot bot removed the triage label Dec 9, 2021
@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #24355, and a fix will be available in an upcoming release of Ionic Framework.

@Predarion
Copy link
Author

@liamdebeasi thanks for fixing that fast! Locally, another issue occurs that might also be resolved with this fix. Do you have a dev build available which I could use to test this out?

@liamdebeasi
Copy link
Contributor

Sure! Here is the dev build. Note that this is an Ionic 5 dev build, though the fix will be available in both Ionic 5 and Ionic 6:

npm install @ionic/[email protected] @ionic/[email protected]

@liamdebeasi
Copy link
Contributor

This has been released in Ionic 6.0.1 and Ionic 5.9.3. Ionic 5 users can use the v5-lts tag to get the latest version of Ionic 5:

npm install @ionic/vue@v5-lts @ionic/vue-router@v5-lts

@ionitron-bot
Copy link

ionitron-bot bot commented Jan 14, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: vue @ionic/vue package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants