-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Ionic Vue Router throwing error when its running on server in SSR mode. #23254
Comments
Thanks for the issue and PR! Could your provide some more steps to reproduce? I am trying to run the app in SSR mode, but I do not get the |
In the repo, I forgot to add back vue-router dependency as I was testing without ionic-router which I did now. you can run the same now. I have recorded a video demonstrating the issue, please find the link here. |
Thanks, that makes sense. I left a comment on your PR. |
Also here is a dev build of your changes if you would like to test them in your app:
|
Thanks for the issue. This has been resolved via #23255, and a fix will be available in an upcoming release of Ionic Framework. |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Bug Report
Ionic version:
[ ] 4.x
[x] 5.x
Current behavior:
Running ionic vue with SSR with ionic router, the @ionic/vue-router throws an error about history is not defined when it is running on server.
Expected behavior:
The error should not trigger.
Steps to reproduce:
clone the repo https://github.com/mohammadsiddiqui/vue-ionic-ssr and build it and run it in SSR mode and look at the server console.
Related code:
Other information:
Ionic info:
The text was updated successfully, but these errors were encountered: