Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ion-range with bottom-drawer #22335

Closed
roman-rr opened this issue Oct 16, 2020 · 8 comments · Fixed by #22407
Closed

bug: ion-range with bottom-drawer #22335

roman-rr opened this issue Oct 16, 2020 · 8 comments · Fixed by #22407
Labels
Milestone

Comments

@roman-rr
Copy link

Bug Report

Ionic version:

[ ] 4.x
[x] 5.x

Current behavior:
ion-range drag events disabled after present inside pane.
important note: drag event's works well if pane presented immediately after DOM render

Expected behavior:
Drag events works for ion-range within Pane, even if Pane presented after some delay or with button.

Steps to reproduce:

  1. Open link https://output.jsbin.com/dojoxiz
  2. Click to Present Pane
  3. Try to drag range knobs
  4. Open second example where pane presented immediately https://output.jsbin.com/dutuciv
  5. Try to drag range knobs

Related code:

Demo live
Demo immediately presented live

@roman-rr
Copy link
Author

@liamdebeasi have you chance to look up ?

@liamdebeasi
Copy link
Contributor

Are you able to reproduce this without the drawer component? If not, is it possible something in the drawer component gesture is interfering with the range gesture?

@roman-rr
Copy link
Author

@liamdebeasi ok, I will check once again

@roman-rr
Copy link
Author

@liamdebeasi
Simple example without Drawer: https://output.jsbin.com/xufazic
Bug faces when appear element with ion-range inside to any other element with .append() method.

let rangeElement = document.querySelector('#range'); // Container with ion-range
let newContainer = document.querySelector('#new-container'); // New empty div container
newContainer.append(rangeElement); // We lose drag ability after append

@sohep
Copy link

sohep commented Oct 30, 2020

Is there any solution yet ?

@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #22407, and a fix will be available in an upcoming release of Ionic Framework.

@roman-rr
Copy link
Author

roman-rr commented Nov 2, 2020

Big thanks for collaboration!

@liamdebeasi liamdebeasi added this to the 5.4.2 milestone Nov 2, 2020
@ionitron-bot
Copy link

ionitron-bot bot commented Dec 2, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants