feat(alert): alert input custom attributes

[cerkiner]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally and any changes were pushed
• Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

No custom attributes can be added for the inputs in the alert controller. Maxlength, pattern, class etc. attributes can be greatly useful when added to the inputs in the alert controller. I think we should be able to add such features.

Issue Number: resolves #21202, #21290, #7819

What is the new behavior?

This change introduces 'cssClass' and 'attributes' properties for inputs.

let alert = this.alertCtrl.create({
    inputs: [
      {
        ...
        cssClass: 'anyClass',
        attributes: { 
                inputmode: 'decimal',
                minlength: 1,
                maxlength: 4,
                autocomplete: 'off',
                ...
        }
        ...
      }
    ]
  });
  alert.present();
}

Does this introduce a breaking change?

• Yes
• No

Other information

[cerkiner]

npm run build process in core directory upgraded slides/swiper/swiper.bundle.js.
I have committed this change separately in 3e9919c

I am not sure if it belongs here.

Edit; test-core-clean-build fails because of this file.

[cerkiner]

I rebased all to current master to resolve the issue. I removed that commit and updated the branch. Now, all checks have passed and the change looks fine.

[liamdebeasi]

Looks good so far! We are discussing how we want to document this, but the functionality works well.

[cerkiner]

The latest change lets the user completely override all attributes except onInput, class and disabled. The reason behind this is overriding these attributes can cause unexpected issues.

• In the case of overriding onInput, values are not synced properly. Fixing this was essential for passing value changes on dismiss.

• In the case of overriding class, input losses ionic designs. Fixing this was important to provide a better look.

• In the case of overriding disabled, dom disabled state and ionic disabled classes were mixed. Fixing this was important to reflect a better look and functionality.

Users are still able to set these attributes but they are not overridden completely. They are merged for an optimum solution, please check and comment on the end result.

[liamdebeasi]

Looks good! A few more small things I noticed.

[cerkiner]

• Unnecessary tests are removed. (I copied the same input in all tests only because I didn't fully understand the purposes of those.)

• About disabled property, I got your point, I made a change to ensure higher specificity always wins.

{
  disabled: true,
  attributes: {
    disabled: false
  }
}

Results in false.

• I merged the latest master to the branch, resolved the conflicts.

[liamdebeasi]

One last comment then I think we're good to go 😄

[cerkiner]

resolved the conflicts for the latest master branch 👍

[liamdebeasi]

Great job!