Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textarea): native textarea inherits max-width and max-height #21333

Merged
merged 7 commits into from
May 19, 2020

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: fixes #18543

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label May 18, 2020
@liamdebeasi liamdebeasi marked this pull request as ready for review May 18, 2020 20:33
@liamdebeasi liamdebeasi requested a review from brandyscarney May 18, 2020 20:33
core/src/components/textarea/textarea.scss Outdated Show resolved Hide resolved
core/src/components/textarea/textarea.scss Outdated Show resolved Hide resolved
@liamdebeasi liamdebeasi merged commit 2377480 into master May 19, 2020
@liamdebeasi liamdebeasi deleted the textarea-max branch May 19, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: ion-textarea minRows/maxRows
2 participants